Focus first invalid field of payment request editor

chrome/browser/ui/views/payments/editor_view_controller.h

Index: chrome/browser/ui/views/payments/editor_view_controller.h
diff --git a/chrome/browser/ui/views/payments/editor_view_controller.h b/chrome/browser/ui/views/payments/editor_view_controller.h
index da5410f03096efbbff0bed5dbb861d4d5465d067..4d8f9dbb41fc7e3a7f0c4e15e4a1a2e47cb3c247 100644
--- a/chrome/browser/ui/views/payments/editor_view_controller.h
+++ b/chrome/browser/ui/views/payments/editor_view_controller.h
@@ -109,9 +109,11 @@ class EditorViewController : public PaymentRequestSheetController,
  protected:
   // Create a header view to be inserted before all fields.
   virtual std::unique_ptr<views::View> CreateHeaderView();
-  // Create a custom view for the specified |type|.
+  // |focusable_field| is to be set with a pointer to the view that should get
+  // default focus without the custom view.
   virtual std::unique_ptr<views::View> CreateCustomFieldView(
-      autofill::ServerFieldType type);
+      autofill::ServerFieldType type,
+      views::View** focusable_field);
   // Create an extra view to go to the right of the field with |type|, which
   // can either be a textfield, combobox, or custom view.
   virtual std::unique_ptr<views::View> CreateExtraViewForField(
@@ -160,8 +162,11 @@ class EditorViewController : public PaymentRequestSheetController,
   // Adds some views to |layout|, to represent an input field and its labels.
   // |field| is the field definition, which contains the label and the hint
   // about the length of the input field. A placeholder error label is also
-  // added (see implementation).
-  void CreateInputField(views::GridLayout* layout, const EditorField& field);
+  // added (see implementation). Returns a pointer to a view filled with a valid
+  // field value that could receive the initial focus if not invalid value is

[anthonyvd, 2017/05/12 14:19:44]

I'm not sure what this means? Does it return any valid field if there's no
invalid one?

[MAD, 2017/05/18 16:01:45]

Rephrased. Better?

[anthonyvd, 2017/05/18 18:12:24]

Yep, thanks!

+  // found.
+  views::View* CreateInputField(views::GridLayout* layout,
+                                const EditorField& field);
 
   // Returns the widest column width of across all extra views of a certain
   // |size| type.
@@ -176,7 +181,7 @@ class EditorViewController : public PaymentRequestSheetController,
   // Tracks the relationship between a field and its error label.
   ErrorLabelMap error_labels_;
 
-  // The first label in the editor, used to set the initial focus.
+  // The first, potentially invalid, field in the editor, used to set the focus.
   views::View* first_field_view_;
 
   // Identifies where to go back when the editing completes successfully.