Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2472)

Unified Diff: chrome/browser/ui/views/payments/validating_textfield_unittest.cc

Issue 2881643002: Focus first invalid field of payment request editor (Closed)
Patch Set: Last final nit :-) Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/payments/validating_textfield_unittest.cc
diff --git a/chrome/browser/ui/views/payments/validating_textfield_unittest.cc b/chrome/browser/ui/views/payments/validating_textfield_unittest.cc
index 6260c40b5280657f814f8db6b94791d8a248e6d9..6a3b57b2fa0225e346ae2d5b6624a88c861fa720 100644
--- a/chrome/browser/ui/views/payments/validating_textfield_unittest.cc
+++ b/chrome/browser/ui/views/payments/validating_textfield_unittest.cc
@@ -28,11 +28,17 @@ class ValidatingTextfieldTest : public testing::Test {
~TestValidationDelegate() override {}
// ValidationDelegate:
- bool ValidateTextfield(views::Textfield* textfield) override {
+ bool TextfieldValueChanged(views::Textfield* textfield) override {
+ return IsValidTextfield(textfield);
+ }
+ bool ComboboxValueChanged(views::Combobox* combobox) override {
+ return IsValidCombobox(combobox);
+ }
+ bool IsValidTextfield(views::Textfield* textfield) override {
// We really don't like textfields with more than 5 characters in them.
return textfield->text().size() <= 5u;
}
- bool ValidateCombobox(views::Combobox* combobox) override { return true; }
+ bool IsValidCombobox(views::Combobox* combobox) override { return true; }
void ComboboxModelChanged(views::Combobox* combobox) override {}
private:
« no previous file with comments | « chrome/browser/ui/views/payments/validating_textfield.cc ('k') | chrome/browser/ui/views/payments/validation_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698