Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5659)

Unified Diff: chrome/browser/ui/views/payments/validating_combobox.cc

Issue 2881643002: Focus first invalid field of payment request editor (Closed)
Patch Set: Last final nit :-) Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/payments/validating_combobox.cc
diff --git a/chrome/browser/ui/views/payments/validating_combobox.cc b/chrome/browser/ui/views/payments/validating_combobox.cc
index d9e26811e9cf88f850f66b0c188e7823ee2bf2b9..080bb85876ebc9f631dd40d568cce959a59a1dc8 100644
--- a/chrome/browser/ui/views/payments/validating_combobox.cc
+++ b/chrome/browser/ui/views/payments/validating_combobox.cc
@@ -53,9 +53,15 @@ void ValidatingCombobox::OnComboboxModelChanged(
delegate_->ComboboxModelChanged(this);
}
+bool ValidatingCombobox::IsValid() {
+ bool valid = delegate_->IsValidCombobox(this);
+ SetInvalid(!valid);
+ return valid;
+}
+
void ValidatingCombobox::Validate() {
- // ValidateCombobox may have side-effects, such as displaying errors.
- SetInvalid(!delegate_->ValidateCombobox(this));
+ // ComboboxValueChanged may have side-effects, such as displaying errors.
+ SetInvalid(!delegate_->ComboboxValueChanged(this));
}
} // namespace payments
« no previous file with comments | « chrome/browser/ui/views/payments/validating_combobox.h ('k') | chrome/browser/ui/views/payments/validating_textfield.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698