chrome/browser/ui/views/payments/payment_request_browsertest_base.cc - Issue 2881643002: Focus first invalid field of payment request editor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/payments/payment_request_browsertest_base.cc

Issue 2881643002: Focus first invalid field of payment request editor (Closed)

Patch Set: Last final nit :-) Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/payments/editor_view_controller.cc ('k') | chrome/browser/ui/views/payments/payment_request_dialog_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/payments/payment_request_browsertest_base.cc

diff --git a/chrome/browser/ui/views/payments/payment_request_browsertest_base.cc b/chrome/browser/ui/views/payments/payment_request_browsertest_base.cc

index 63408a9643fc1eb720ac69c5f8f5adb5296c443e..f5c034ae1f491c7596073400d668cfbe9c0528f2 100644

--- a/chrome/browser/ui/views/payments/payment_request_browsertest_base.cc

+++ b/chrome/browser/ui/views/payments/payment_request_browsertest_base.cc

@@ -592,8 +592,9 @@ void PaymentRequestBrowserTestBase::SelectBillingAddress(

ASSERT_NE(address_combobox, nullptr);

autofill::AddressComboboxModel* address_combobox_model(

static_cast<autofill::AddressComboboxModel*>(address_combobox->model()));

- address_combobox->SetSelectedIndex(

+ address_combobox->SetSelectedRow(

address_combobox_model->GetIndexOfIdentifier(billing_address_id));

+ address_combobox->OnBlur();

}

bool PaymentRequestBrowserTestBase::IsEditorTextfieldInvalid(