Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1136)

Unified Diff: chrome/browser/ui/views/payments/credit_card_editor_view_controller.h

Issue 2881643002: Focus first invalid field of payment request editor (Closed)
Patch Set: Last final nit :-) Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/payments/credit_card_editor_view_controller.h
diff --git a/chrome/browser/ui/views/payments/credit_card_editor_view_controller.h b/chrome/browser/ui/views/payments/credit_card_editor_view_controller.h
index b03b3ada85a2462e8059cedd0395824fc7f2988d..aacf239c9370225d75c98d2f1cdc3ce6ffae5162 100644
--- a/chrome/browser/ui/views/payments/credit_card_editor_view_controller.h
+++ b/chrome/browser/ui/views/payments/credit_card_editor_view_controller.h
@@ -78,13 +78,18 @@ class CreditCardEditorViewController : public EditorViewController {
~CreditCardValidationDelegate() override;
// ValidationDelegate:
- bool ValidateTextfield(views::Textfield* textfield) override;
- bool ValidateCombobox(views::Combobox* combobox) override;
+ bool IsValidTextfield(views::Textfield* textfield) override;
+ bool IsValidCombobox(views::Combobox* combobox) override;
+ bool TextfieldValueChanged(views::Textfield* textfield) override;
+ bool ComboboxValueChanged(views::Combobox* combobox) override;
void ComboboxModelChanged(views::Combobox* combobox) override {}
private:
- // Validates a specific |value|.
- bool ValidateValue(const base::string16& value);
+ // Validates a specific |value|/|combobox|.
+ bool ValidateValue(const base::string16& value,
+ base::string16* error_message);
+ bool ValidateCombobox(views::Combobox* combobox,
+ base::string16* error_message);
EditorField field_;
// Outlives this class.

Powered by Google App Engine
This is Rietveld 408576698