chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc - Issue 2881643002: Focus first invalid field of payment request editor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc

Issue 2881643002: Focus first invalid field of payment request editor (Closed)

Patch Set: Updated API to create field views other small tweaks. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc ('k') | chrome/browser/ui/views/payments/editor_view_controller.h » ('j') | chrome/browser/ui/views/payments/editor_view_controller.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc

diff --git a/chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc b/chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc

index 471ace6096f838d904fd4d9831abcd16ad039ad2..c340511c12aed498a8c4941f1d9606f14d9de387 100644

--- a/chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc

+++ b/chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc

@@ -599,7 +599,7 @@ IN_PROC_BROWSER_TEST_F(PaymentRequestCreditCardEditorTest, EnteringEmptyData) {

static_cast<ValidatingTextfield*>(dialog_view()->GetViewByID(

static_cast<int>(autofill::CREDIT_CARD_NAME_FULL)));

EXPECT_TRUE(textfield);

- EXPECT_TRUE(textfield->invalid());

+ EXPECT_FALSE(textfield->IsValid());

}

} // namespace payments