Issue 2881623002: Do not wrap a PCC sender with a PacingSender.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2881623002: Do not wrap a PCC sender with a PacingSender. (Closed)

Created:
3 years, 7 months ago by mpw

Modified:
3 years, 7 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Do not wrap a PCC sender with a PacingSender. Right now, we cannot just blindly wrap a PCC-based sender with a PacingSender. Some SendAlgorithms can be wrapped by a pacer and some cannot. By default, do not wrap a PCC sender with a pacer. Merge internal change: 155393218 R=rch@chromium.org BUG=

Patch Set 1 #

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+83 lines, -1 line)			Patch
M	net/quic/core/quic_connection_test.cc	View	12 chunks	+12 lines, -0 lines	0 comments	Download
M	net/quic/core/quic_sent_packet_manager.cc	View	1 chunk	+7 lines, -1 line	0 comments	Download
M	net/quic/core/quic_sent_packet_manager_test.cc	View	20 chunks	+64 lines, -0 lines	0 comments	Download

Depends on Patchset:

Issue 2872133008 Patch 1

Dependent Patchsets:

Issue 2879533003 Patch 1

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages