Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1143)

Unified Diff: pkg/compiler/lib/src/kernel/fasta_support.dart

Issue 2881603003: Generate outline without transformations in patched_sdk, use it for unit tests (Closed)
Patch Set: really use the outline, really Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/kernel/fasta_support.dart
diff --git a/pkg/compiler/lib/src/kernel/fasta_support.dart b/pkg/compiler/lib/src/kernel/fasta_support.dart
index 9a2b034a712b43ec77a5af668b4ff544df4fcfcb..df7148aa6a4034c4b68ad52004b5843a3b3c5530 100644
--- a/pkg/compiler/lib/src/kernel/fasta_support.dart
+++ b/pkg/compiler/lib/src/kernel/fasta_support.dart
@@ -34,8 +34,9 @@ import 'package:front_end/src/fasta/translate_uri.dart' show TranslateUri;
/// Generates a platform.dill file containing the compiled Kernel IR of the
/// dart2js SDK.
-Future compilePlatform(Uri patchedSdk, Uri output, {Uri packages}) async {
- Uri deps = Uri.base.resolveUri(new Uri.file("${output.toFilePath()}.d"));
+Future compilePlatform(Uri patchedSdk, Uri fullOutput,
+ {Uri outlineOutput, Uri packages}) async {
+ Uri deps = Uri.base.resolveUri(new Uri.file("${fullOutput.toFilePath()}.d"));
TranslateUri uriTranslator = await TranslateUri.parse(
PhysicalFileSystem.instance, patchedSdk, packages);
var ticker = new Ticker(isVerbose: false);
@@ -45,11 +46,11 @@ Future compilePlatform(Uri patchedSdk, Uri output, {Uri packages}) async {
kernelTarget.read(Uri.parse("dart:core"));
await dillTarget.writeOutline(null);
- await kernelTarget.writeOutline(output);
+ await kernelTarget.writeOutline(outlineOutput);
if (exitCode != 0) return null;
- await kernelTarget.writeProgram(output);
- await kernelTarget.writeDepsFile(output, deps);
+ await kernelTarget.writeProgram(fullOutput);
+ await kernelTarget.writeDepsFile(fullOutput, deps);
}
/// Extends the internal fasta [CompileTask] to use a dart2js-aware [DillTarget]
« no previous file with comments | « no previous file | pkg/front_end/lib/src/fasta/compile_platform.dart » ('j') | pkg/front_end/test/fasta/testing/suite.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698