content/common/net/reporting.mojom - Issue 2881593002: Reporting: Plumb into RenderFrame via Mojo

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/common/net/reporting.mojom

Issue 2881593002: Reporting: Plumb into RenderFrame via Mojo (Closed)

Patch Set: Add username to TODOs, rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 module content.mojom;

	6

	7 import "mojo/common/values.mojom";

	8 import "url/mojo/url.mojom";

	9

	10 interface ReportingServiceProxy {

	11 QueueReport(url.mojom.Url url,
	dcheng 2017/05/19 13:42:55 Nit: please add some comments to this interface an Nit: please add some comments to this interface and its methods. In particular, please describe what \|group\| and \|type\| are, and if there are any restrictions on the inputs, since they're just strings. Julia Tuttle 2017/05/19 16:12:22 Done. Show quoted text On 2017/05/19 13:42:55, dcheng (in AEST) wrote: > Nit: please add some comments to this interface and its methods. In particular, > please describe what \|group\| and \|type\| are, and if there are any restrictions > on the inputs, since they're just strings. Done.
	12 string group,

	13 string type,

	14 mojo.common.mojom.Value body);

	15 };

OLD	NEW