Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1400)

Unified Diff: media/video/picture.h

Issue 2881553002: Add |texture_target_| and |pixel_format_| to media::PictureBuffer (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/video/picture.h
diff --git a/media/video/picture.h b/media/video/picture.h
index 097ea774c6e44bad840e7505c1179222295925c4..8986301c235e53dc2ffdb5bd28369ac356e18deb 100644
--- a/media/video/picture.h
+++ b/media/video/picture.h
@@ -11,6 +11,7 @@
#include "gpu/command_buffer/common/mailbox.h"
#include "media/base/media_export.h"
+#include "media/base/video_types.h"
#include "ui/gfx/color_space.h"
#include "ui/gfx/geometry/rect.h"
#include "ui/gfx/geometry/size.h"
@@ -34,6 +35,8 @@ class MEDIA_EXPORT PictureBuffer {
PictureBuffer(int32_t id,
const gfx::Size& size,
const TextureIds& client_texture_ids,
+ uint32_t texture_target,
+ VideoPixelFormat pixel_format,
const std::vector<gpu::Mailbox>& texture_mailboxes);
PictureBuffer(const PictureBuffer& other);
~PictureBuffer();
@@ -53,6 +56,10 @@ class MEDIA_EXPORT PictureBuffer {
// |client_texture_ids|.
const TextureIds& service_texture_ids() const { return service_texture_ids_; }
+ uint32_t texture_target() const { return texture_target_; }
+
+ VideoPixelFormat pixel_format() const { return pixel_format_; }
+
gpu::Mailbox texture_mailbox(size_t plane) const;
private:
@@ -60,6 +67,8 @@ class MEDIA_EXPORT PictureBuffer {
gfx::Size size_;
TextureIds client_texture_ids_;
TextureIds service_texture_ids_;
+ uint32_t texture_target_;
liberato (no reviews please) 2017/05/11 16:24:40 this seems to be left uninitialized in some constr
Chandan 2017/05/12 13:47:51 Done.
+ VideoPixelFormat pixel_format_;
liberato (no reviews please) 2017/05/11 16:24:40 same here.
Chandan 2017/05/12 13:47:51 Done.
std::vector<gpu::Mailbox> texture_mailboxes_;
};

Powered by Google App Engine
This is Rietveld 408576698