Add |texture_target_| and |pixel_format_| to media::PictureBuffer

media/gpu/ipc/service/gpu_video_decode_accelerator.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/gpu/ipc/service/gpu_video_decode_accelerator.h"
 
 #include <memory>
 #include <vector>
 
 #include "base/bind.h"
@@ skipping 382 matching lines @@
 // Runs on IO thread if VDA::TryToSetupDecodeOnSeparateThread() succeeded,
 // otherwise on the main thread.
 void GpuVideoDecodeAccelerator::OnDecode(
     const BitstreamBuffer& bitstream_buffer) {
   DCHECK(video_decode_accelerator_);
   video_decode_accelerator_->Decode(bitstream_buffer);
 }
 
 void GpuVideoDecodeAccelerator::OnAssignPictureBuffers(
     const std::vector<int32_t>& buffer_ids,
-    const std::vector<PictureBuffer::TextureIds>& texture_ids) {
+    const std::vector<PictureBuffer::TextureIds>& texture_ids,
+    const std::vector<uint32_t>& texture_targets,
+    const std::vector<VideoPixelFormat>& formats,
+    const std::vector<gfx::Size>& sizes) {
   if (buffer_ids.size() != texture_ids.size()) {
     NotifyError(VideoDecodeAccelerator::INVALID_ARGUMENT);
     return;
   }
 
   gpu::gles2::GLES2Decoder* command_decoder = stub_->decoder();
   gpu::gles2::TextureManager* texture_manager =
       command_decoder->GetContextGroup()->texture_manager();
 
   std::vector<PictureBuffer> buffers;
@@ skipping 57 matching lines @@
           DCHECK(format == GL_BGRA_EXT);
           texture_manager->SetLevelInfo(texture_ref, texture_target_, 0, format,
                                         width, height, 1, 0, format,
                                         GL_UNSIGNED_BYTE, gfx::Rect());
         }
       }
       service_ids.push_back(texture_ref->service_id());
       current_textures.push_back(texture_ref);
     }
     textures.push_back(current_textures);
     buffers.push_back(PictureBuffer(buffer_ids[i], texture_dimensions_,

[liberato (no reviews please), 2017/05/12 21:26:42]

i had forgotten that |texture_dimensions_| is cached here.  if you'd like to
mirror this approach for format and target, rather than sending via IPC, that
works too.  sorry about the confusion.

if you choose to keep IPC, then |texture_dimensions_| can be removed from
GpuVideoDecoder entirely, i think.

[Chandan, 2017/05/16 14:29:30]

Done.

                                     buffer_texture_ids, service_ids));
   }
   {
     DebugAutoLock auto_lock(debug_uncleared_textures_lock_);
     for (uint32_t i = 0; i < buffer_ids.size(); ++i)
       uncleared_textures_[buffer_ids[i]] = textures[i];
   }
   video_decode_accelerator_->AssignPictureBuffers(buffers);
 }
 
@@ skipping 39 matching lines @@
   for (auto texture_ref : it->second) {
     GLenum target = texture_ref->texture()->target();
     gpu::gles2::TextureManager* texture_manager =
         stub_->decoder()->GetContextGroup()->texture_manager();
     texture_manager->SetLevelCleared(texture_ref.get(), target, 0, true);
   }
   uncleared_textures_.erase(it);
 }
 
 }  // namespace media