Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2881533002: Add a test requiring Kernel's Erasure pass (Closed)

Created:
3 years, 7 months ago by Kevin Millikin (Google)
Modified:
3 years, 7 months ago
Reviewers:
jensj
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a test requiring Kernel's Erasure pass This test will crash if Erasure is not run. BUG= R=jensj@google.com Committed: https://github.com/dart-lang/sdk/commit/c655dff16173e7ff8934ec300f8c711fe393e333

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
A tests/kernel/unsorted/generic_function_test.dart View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Kevin Millikin (Google)
3 years, 7 months ago (2017-05-11 09:25:16 UTC) #2
jensj
lgtm
3 years, 7 months ago (2017-05-11 09:25:39 UTC) #3
Kevin Millikin (Google)
3 years, 7 months ago (2017-05-11 09:34:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c655dff16173e7ff8934ec300f8c711fe393e333 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698