Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Unified Diff: components/security_state/content/content_utils_unittest.cc

Issue 2881513003: DevTools: Convert Security Panel to Sentence case (Closed)
Patch Set: Fix hardcoded UnitTest Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/security_state/content/content_utils_unittest.cc
diff --git a/components/security_state/content/content_utils_unittest.cc b/components/security_state/content/content_utils_unittest.cc
index a9b5bbdccedf0e3e26d0380ed2eab2ea87e4fd22..b8203930bfd9c8a161e7d12167c2acff6ad12292 100644
--- a/components/security_state/content/content_utils_unittest.cc
+++ b/components/security_state/content/content_utils_unittest.cc
@@ -8,6 +8,7 @@
#include "base/test/histogram_tester.h"
#include "components/security_state/core/security_state.h"
#include "components/security_state/core/switches.h"
+#include "components/strings/grit/components_strings.h"
#include "content/public/browser/security_style_explanation.h"
#include "content/public/browser/security_style_explanations.h"
#include "net/cert/cert_status_flags.h"
@@ -16,6 +17,7 @@
#include "net/test/cert_test_util.h"
#include "net/test/test_data_directory.h"
#include "testing/gtest/include/gtest/gtest.h"
+#include "ui/base/l10n/l10n_util.h"
namespace {
@@ -150,7 +152,7 @@ TEST(SecurityStateContentUtilsTest, GetSecurityStyleForMixedContent) {
bool FindSecurityStyleExplanation(
const std::vector<content::SecurityStyleExplanation>& explanations,
- const char* summary,
+ const std::string& summary,
content::SecurityStyleExplanation* explanation) {
for (const auto& entry : explanations) {
if (entry.summary == summary) {
@@ -181,7 +183,8 @@ TEST(SecurityStateContentUtilsTest, ConnectionExplanation) {
GetSecurityStyle(security_info, &explanations);
content::SecurityStyleExplanation explanation;
ASSERT_TRUE(FindSecurityStyleExplanation(
- explanations.secure_explanations, "Secure Connection", &explanation));
+ explanations.secure_explanations,
+ l10n_util::GetStringUTF8(IDS_STRONG_SSL_SUMMARY), &explanation));
EXPECT_EQ(
"The connection to this site is encrypted and authenticated using a "
"strong protocol (TLS 1.2), a strong key exchange (ECDHE_RSA with "
@@ -197,7 +200,8 @@ TEST(SecurityStateContentUtilsTest, ConnectionExplanation) {
GetSecurityStyle(security_info, &explanations);
content::SecurityStyleExplanation explanation;
ASSERT_TRUE(FindSecurityStyleExplanation(
- explanations.secure_explanations, "Secure Connection", &explanation));
+ explanations.secure_explanations,
+ l10n_util::GetStringUTF8(IDS_STRONG_SSL_SUMMARY), &explanation));
EXPECT_EQ(
"The connection to this site is encrypted and authenticated using a "
"strong protocol (TLS 1.2), a strong key exchange (ECDHE_RSA), and a "
@@ -216,7 +220,8 @@ TEST(SecurityStateContentUtilsTest, ConnectionExplanation) {
GetSecurityStyle(security_info, &explanations);
content::SecurityStyleExplanation explanation;
ASSERT_TRUE(FindSecurityStyleExplanation(
- explanations.secure_explanations, "Secure Connection", &explanation));
+ explanations.secure_explanations,
+ l10n_util::GetStringUTF8(IDS_STRONG_SSL_SUMMARY), &explanation));
EXPECT_EQ(
"The connection to this site is encrypted and authenticated using a "
"strong protocol (TLS 1.3), a strong key exchange (X25519), and a "

Powered by Google App Engine
This is Rietveld 408576698