Make update over cellular an option for user

chromeos/dbus/update_engine_client.h

Index: chromeos/dbus/update_engine_client.h
diff --git a/chromeos/dbus/update_engine_client.h b/chromeos/dbus/update_engine_client.h
index 94c89ea7b50546c2f449b43f537636602f90d047..a52143376c8de2621fb712a60d55e335f49dbb5e 100644
--- a/chromeos/dbus/update_engine_client.h
+++ b/chromeos/dbus/update_engine_client.h
@@ -40,7 +40,8 @@ class CHROMEOS_EXPORT UpdateEngineClient : public DBusClient {
     UPDATE_STATUS_FINALIZING,
     UPDATE_STATUS_UPDATED_NEED_REBOOT,
     UPDATE_STATUS_REPORTING_ERROR_EVENT,
-    UPDATE_STATUS_ATTEMPTING_ROLLBACK
+    UPDATE_STATUS_ATTEMPTING_ROLLBACK,
+    UPDATE_STATUS_NEED_PERMISSION_TO_UPDATE

[Daniel Erat, 2017/05/12 13:37:03]

nit: put trailing comma after last item in lists

[weidongg, 2017/05/12 16:33:17]

Done.

   };
 
   // The status of the ongoing update attempt.
@@ -149,6 +150,18 @@ class CHROMEOS_EXPORT UpdateEngineClient : public DBusClient {
       bool allowed,
       const base::Closure& callback) = 0;
 
+  // Called once SetUpdateOverCellularTarget() is complete. Takes one parameter;
+  // - success: indicates whether the target is set successfully.
+  typedef base::Callback<void(bool)> SetTargetCallback;

[Daniel Erat, 2017/05/12 13:37:03]

i think that 'using' is preferred now.

this should probably also be SetUpdateOverCellularTargetCallback.

[weidongg, 2017/05/12 16:33:17]

Do you mean I should 'using base::Callback;' at the beginning of the file?

[Daniel Erat, 2017/05/12 16:44:48]

no, this:

  using SetUpdateOverCellularTargetCallback =
      base::Callback<void(bool success)>;

(i think you can include parameter names in callbacks)

[weidongg, 2017/05/12 17:00:15]

Done.

+
+  // Set the target in the preferences maintained by update engine which then
+  // performs update to this given target after |RequestUpdateCheck| is invoked

[Daniel Erat, 2017/05/12 13:37:03]

i think we usually just use || around variable names. functions are usually
written as RequestUpdateCheck() (including in the comment you added above).

[weidongg, 2017/05/12 16:33:16]

Done.

+  // in the |callback|.
+  virtual void SetUpdateOverCellularTarget(
+      const std::string& target_version,
+      int64_t target_size,

[Daniel Erat, 2017/05/12 13:37:03]

please document what target_version and target_size contain. is target_version a
chrome os version number? mind giving an example?

[weidongg, 2017/05/12 16:33:17]

Ok, I add explanation.

+      const SetTargetCallback& callback) = 0;
+
   // Returns an empty UpdateCheckCallback that does nothing.
   static UpdateCheckCallback EmptyUpdateCheckCallback();