third_party/WebKit/Source/devtools/front_end/profiler/ProfileLauncherView.js - Issue 2881453003: DevTools: update buttons to new style

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/profiler/ProfileLauncherView.js

Issue 2881453003: DevTools: update buttons to new style (Closed)

Patch Set: rebase over cleanup Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/network_conditions/networkConditionsSettingsTab.css ('k') | third_party/WebKit/Source/devtools/front_end/settings/frameworkBlackboxSettingsTab.css » ('j') | third_party/WebKit/Source/devtools/front_end/ui/textButton.css » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/profiler/ProfileLauncherView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/profiler/ProfileLauncherView.js b/third_party/WebKit/Source/devtools/front_end/profiler/ProfileLauncherView.js

index 7cc895cd5a36183a0bcf31cac1e09cdc400bcac6..32917a0931adcfdce33a31d39b27af83513434f8 100644

--- a/third_party/WebKit/Source/devtools/front_end/profiler/ProfileLauncherView.js

+++ b/third_party/WebKit/Source/devtools/front_end/profiler/ProfileLauncherView.js

@@ -47,7 +47,8 @@ Profiler.ProfileLauncherView = class extends UI.VBox {

targetDiv.createChild('div').textContent = Common.UIString('Target:');

var targetsSelect = targetDiv.createChild('select', 'chrome-select');

new Profiler.TargetsComboBoxController(targetsSelect, targetDiv);

- this._controlButton = UI.createTextButton('', this._controlButtonClicked.bind(this), 'profile-launcher-button');

+ this._controlButton =

+ UI.createTextButton('', this._controlButtonClicked.bind(this), 'profile-launcher-button', true /* primary */);

this._contentElement.appendChild(this._controlButton);

this._recordButtonEnabled = true;

this._loadButton =

@@ -74,12 +75,15 @@ Profiler.ProfileLauncherView = class extends UI.VBox {

this._controlButton.title = this._recordButtonEnabled ? '' : UI.anotherProfilerActiveLabel();

if (this._isInstantProfile) {

this._controlButton.classList.remove('running');

+ this._controlButton.classList.add('primary');

this._controlButton.textContent = Common.UIString('Take Snapshot');

} else if (this._isProfiling) {

this._controlButton.classList.add('running');

+ this._controlButton.classList.remove('primary');

this._controlButton.textContent = Common.UIString('Stop');

} else {

this._controlButton.classList.remove('running');

+ this._controlButton.classList.add('primary');

this._controlButton.textContent = Common.UIString('Start');

}

for (var item of this._typeIdToOptionElement.values())