Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/help/ReleaseNoteView.js

Issue 2881453003: DevTools: update buttons to new style (Closed)
Patch Set: find replace updated too! Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 Help.ReleaseNoteView = class extends UI.VBox { 5 Help.ReleaseNoteView = class extends UI.VBox {
6 constructor() { 6 constructor() {
7 super(true); 7 super(true);
8 this.registerRequiredCSS('help/releaseNote.css'); 8 this.registerRequiredCSS('help/releaseNote.css');
9 var releaseNoteElement = this._createReleaseNoteElement(Help.latestReleaseNo te()); 9 var releaseNoteElement = this._createReleaseNoteElement(Help.latestReleaseNo te());
10 var topSection = this.contentElement.createChild('div', 'release-note-top-se ction'); 10 var topSection = this.contentElement.createChild('div', 'release-note-top-se ction');
(...skipping 13 matching lines...) Expand all
24 var listItem = contentContainer.createChild('li'); 24 var listItem = contentContainer.createChild('li');
25 var title = UI.createExternalLink(highlight.link, highlight.title + ' ', ' release-note-title'); 25 var title = UI.createExternalLink(highlight.link, highlight.title + ' ', ' release-note-title');
26 title.title = ''; 26 title.title = '';
27 listItem.appendChild(title); 27 listItem.appendChild(title);
28 var subtitle = UI.createExternalLink(highlight.link, highlight.subtitle + ' ', 'release-note-subtitle'); 28 var subtitle = UI.createExternalLink(highlight.link, highlight.subtitle + ' ', 'release-note-subtitle');
29 subtitle.title = ''; 29 subtitle.title = '';
30 listItem.appendChild(subtitle); 30 listItem.appendChild(subtitle);
31 } 31 }
32 32
33 var actionContainer = container.createChild('div', 'release-note-action-cont ainer'); 33 var actionContainer = container.createChild('div', 'release-note-action-cont ainer');
34 var viewMoreButton = actionContainer.createChild('button'); 34 var viewMoreButton = UI.createTextButton(Common.UIString('Learn more'), even t => {
35 viewMoreButton.textContent = Common.UIString('Learn more');
36 viewMoreButton.addEventListener('click', event => {
37 event.consume(true); 35 event.consume(true);
38 InspectorFrontendHost.openInNewTab(releaseNote.link); 36 InspectorFrontendHost.openInNewTab(releaseNote.link);
39 }); 37 });
40 38 var closeButton = UI.createTextButton(Common.UIString('Close'), event => {
41 var closeButton = actionContainer.createChild('button', 'close-release-note' );
42 closeButton.textContent = Common.UIString('Close');
43 closeButton.addEventListener('click', event => {
44 event.consume(true); 39 event.consume(true);
45 UI.inspectorView.closeDrawerTab(Help._releaseNoteViewId, true); 40 UI.inspectorView.closeDrawerTab(Help._releaseNoteViewId, true);
46 }); 41 });
47 42
43 actionContainer.appendChild(viewMoreButton);
dgozman 2017/05/15 21:29:00 nit: can inline this
luoe 2017/05/18 21:29:25 Done.
44 actionContainer.appendChild(closeButton);
45
48 var imageLink = UI.createExternalLink(releaseNote.link, ' '); 46 var imageLink = UI.createExternalLink(releaseNote.link, ' ');
49 imageLink.classList.add('release-note-image'); 47 imageLink.classList.add('release-note-image');
50 imageLink.title = ''; 48 imageLink.title = '';
51 hbox.appendChild(imageLink); 49 hbox.appendChild(imageLink);
52 var image = imageLink.createChild('img'); 50 var image = imageLink.createChild('img');
53 image.src = 'Images/whatsnew.png'; 51 image.src = 'Images/whatsnew.png';
54 return hbox; 52 return hbox;
55 } 53 }
56 }; 54 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698