[VrShell] Mask system ui flags before checking.

chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java

Index: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
index 3140ea2a30068689a6b33191498948d3a183dd4d..2a17e74ce1b6079d0baaa3c6411777e217a3b203 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
@@ -533,7 +533,9 @@ public class VrShellDelegate implements ApplicationStatus.ActivityStateListener,
     private boolean isWindowModeCorrectForVr() {
         int flags = mActivity.getWindow().getDecorView().getSystemUiVisibility();
         int orientation = mActivity.getResources().getConfiguration().orientation;
-        return flags == VR_SYSTEM_UI_FLAGS && orientation == Configuration.ORIENTATION_LANDSCAPE;
+        // Mask the flags to only those that we care about.
+        return (flags & VR_SYSTEM_UI_FLAGS) == VR_SYSTEM_UI_FLAGS

[billorr1, 2017/05/16 21:50:05]

Are there any flags we want to ensure are not set?  There are only two that we
don't have set currently (*LOW_PROFILE and *HIDDEN), not sure if those could
interact with other flags in a negative way.

[mthiesse, 2017/05/16 21:56:14]

We probably want to make sure that we don't have SYSTEM_UI_FLAG_VISIBLE.

[amp, 2017/05/16 22:19:54]

I'm not sure.  It's possible we may have to adjust these in future SDK
revisions, but these seem to work for now (albeit I only tested on s8 and
pixel).

I'll have the testers try out on more varying devices to make sure nothing odd
pops up when this goes in.

Anyway, I understand the concern, as according to the spec
https://developer.android.com/reference/android/view/View.html#getSystemUiVis...
getSystemUiVisibility is only supposed to return the values that you set.  So
really we shouldn't need to mask at all.

I'm open to other suggestions as to better mitigate this, any ideas?

+                && orientation == Configuration.ORIENTATION_LANDSCAPE;
     }
 
     private void setWindowModeForVr(int requestedOrientation) {