third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp - Issue 2881393002: Count cross-origin property access.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

Issue 2881393002: Count cross-origin property access. (Closed)

Patch Set: Nits + Rebase. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

diff --git a/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp b/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

index 1e6b1b694ac7b88a8a454348bce30302a726f0e7..bd10ab0c91e6723556f3074c0c7b140f7b5cbdf6 100644

--- a/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

+++ b/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

@@ -1658,8 +1658,9 @@ DOMWindow* LocalDOMWindow::open(const String& url_string,

if (target_frame) {

if (!active_document->GetFrame() ||

- !active_document->GetFrame()->CanNavigate(*target_frame))

+ !active_document->GetFrame()->CanNavigate(*target_frame)) {

return nullptr;

+ }

KURL completed_url = first_frame->GetDocument()->CompleteURL(url_string);