Issue 288133005: Helper classes for java bindings.

Issue 288133005: Helper classes for java bindings. (Closed)

Created:
6 years, 7 months ago by qsr

Modified:
6 years, 7 months ago

Reviewers:
bulach, viettrungluu, rmcilroy

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Helper classes for java bindings. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270757

Patch Set 3 : Follow review #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+133 lines, -0 lines)			Patch
A	mojo/android/javatests/src/org/chromium/mojo/bindings/BindingsHelperTest.java	View	1	1 chunk	+55 lines, -0 lines	0 comments	Download
A	mojo/bindings/java/src/org/chromium/mojo/bindings/BindingsHelper.java	View	1 2	1 chunk	+64 lines, -0 lines	0 comments	Download
M	mojo/mojo.gyp	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	mojo/mojo_public.gypi	View		1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

qsr

This is some utility classes for the java bindings CL, cut from it to allow ...

6 years, 7 months ago (2014-05-15 08:22:33 UTC) #1

bulach

lgtm, tiny suggestion below. https://codereview.chromium.org/288133005/diff/1/mojo/bindings/java/src/org/chromium/mojo/bindings/BindingsHelper.java File mojo/bindings/java/src/org/chromium/mojo/bindings/BindingsHelper.java (right): https://codereview.chromium.org/288133005/diff/1/mojo/bindings/java/src/org/chromium/mojo/bindings/BindingsHelper.java#newcode26 mojo/bindings/java/src/org/chromium/mojo/bindings/BindingsHelper.java:26: public static int utf8StringLength(String s) ...

6 years, 7 months ago (2014-05-15 13:33:27 UTC) #2

qsr

https://codereview.chromium.org/288133005/diff/1/mojo/bindings/java/src/org/chromium/mojo/bindings/BindingsHelper.java File mojo/bindings/java/src/org/chromium/mojo/bindings/BindingsHelper.java (right): https://codereview.chromium.org/288133005/diff/1/mojo/bindings/java/src/org/chromium/mojo/bindings/BindingsHelper.java#newcode26 mojo/bindings/java/src/org/chromium/mojo/bindings/BindingsHelper.java:26: public static int utf8StringLength(String s) { On 2014/05/15 13:33:28, ...

6 years, 7 months ago (2014-05-15 13:37:42 UTC) #3

rmcilroy

lgtm other than a small nit. https://codereview.chromium.org/288133005/diff/20001/mojo/bindings/java/src/org/chromium/mojo/bindings/BindingsHelper.java File mojo/bindings/java/src/org/chromium/mojo/bindings/BindingsHelper.java (right): https://codereview.chromium.org/288133005/diff/20001/mojo/bindings/java/src/org/chromium/mojo/bindings/BindingsHelper.java#newcode33 mojo/bindings/java/src/org/chromium/mojo/bindings/BindingsHelper.java:33: if (c >= ...

6 years, 7 months ago (2014-05-15 14:02:35 UTC) #4

qsr

https://codereview.chromium.org/288133005/diff/20001/mojo/bindings/java/src/org/chromium/mojo/bindings/BindingsHelper.java File mojo/bindings/java/src/org/chromium/mojo/bindings/BindingsHelper.java (right): https://codereview.chromium.org/288133005/diff/20001/mojo/bindings/java/src/org/chromium/mojo/bindings/BindingsHelper.java#newcode33 mojo/bindings/java/src/org/chromium/mojo/bindings/BindingsHelper.java:33: if (c >= Character.MIN_SURROGATE && c < (Character.MAX_SURROGATE + ...

6 years, 7 months ago (2014-05-15 14:10:59 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/288133005/30001

6 years, 7 months ago (2014-05-15 15:43:24 UTC) #8

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...

6 years, 7 months ago (2014-05-15 18:21:04 UTC) #9

Message was sent while issue was closed.

Change committed as 270757

Expand Messages | Collapse Messages