Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7034)

Unified Diff: chrome/browser/ui/page_info/page_info_ui.cc

Issue 2881203002: [subresource_filter] Add Page Info subtitle on desktop + placeholder string (Closed)
Patch Set: lgarron review Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/page_info/page_info_ui.cc
diff --git a/chrome/browser/ui/page_info/page_info_ui.cc b/chrome/browser/ui/page_info/page_info_ui.cc
index 401b5cd12f5307c98b44dc619dbf3c8189db364e..ffca5ea4e58c5b41e3f171486e9b28de291e7a1e 100644
--- a/chrome/browser/ui/page_info/page_info_ui.cc
+++ b/chrome/browser/ui/page_info/page_info_ui.cc
@@ -339,6 +339,10 @@ base::string16 PageInfoUI::PermissionDecisionReasonToUIString(
}
}
+ if (permission.type == CONTENT_SETTINGS_TYPE_SUBRESOURCE_FILTER) {
+ message_id = IDS_PAGE_INFO_PERMISSION_SUBRESOURCE_FILTER_SUBTITLE;
+ }
raymes 2017/05/15 23:15:50 nit: no {}
Charlie Harrison 2017/05/16 00:42:41 Done.
+
if (message_id == kInvalidResourceID)
return base::string16();
return l10n_util::GetStringUTF16(message_id);
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoPopup.java ('k') | components/page_info_strings.grdp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698