chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoPopup.java - Issue 2881203002: [subresource_filter] Add Page Info subtitle on desktop + placeholder string

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoPopup.java

Issue 2881203002: [subresource_filter] Add Page Info subtitle on desktop + placeholder string (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoPopup.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoPopup.java b/chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoPopup.java

index 953715cb5b9df4f612df7313c83e5dc0bcdd929d..2165c829b8949fe53bfc38e596dfc1b7a8464132 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoPopup.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoPopup.java

@@ -626,7 +626,7 @@ public class PageInfoPopup implements OnClickListener {

TextView permissionUnavailable =

(TextView) permissionRow.findViewById(R.id.page_info_permission_subtitle);

permissionUnavailable.setVisibility(View.VISIBLE);

- permissionUnavailable.setText(R.string.subresource_filter_permission_title);

+ permissionUnavailable.setText(R.string.subresource_filter_page_info_subtitle);

}

TextView permissionStatus = (TextView) permissionRow.findViewById(

« no previous file with comments | « no previous file | chrome/app/generated_resources.grd » ('j') | chrome/app/generated_resources.grd » ('J')