[subresource_filter] Add Page Info subtitle on desktop + placeholder string

components/page_info_strings.grdp

 <?xml version="1.0" encoding="utf-8"?>
 <grit-part>
   <!-- Security summary strings -->
   <!-- TODO(crbug.com/716305): Rename remaining IDS_PAGE_INFO_* strings to IDS_PAGE_INFO_* -->
   <message name="IDS_PAGE_INFO_SECURE_SUMMARY" desc="A short summary phrase at the top of the Page Info bubble (which shows when you click the lock icon) that indicates that the connection to the current website is secure.">
     Secure connection
   </message>
   <message name="IDS_PAGE_INFO_MIXED_CONTENT_SUMMARY" desc="A one-line summary at the top of the Page Info bubble (which shows when you click the security indicator) if the connection to the current website is using mainly using a secure connection but has some insecure parts (like insecurely loaded images).">
     Your connection to this site is not fully secure
   </message>
@@ skipping 278 matching lines @@
     </message>
     <message name="IDS_PAGE_INFO_PERMISSION_BLOCKED_BY_EXTENSION" desc="The label used underneath a permission listed in the Page Info bubble if the permission was explicitly blocked by one of the user's extensions.">
       Blocked by an extension
     </message>
     <message name="IDS_PAGE_INFO_PERMISSION_ASK_BY_EXTENSION" desc="The label used underneath a permission listed in the Page Info bubble if the permission was explicitly set to 'Ask' by one of the user's extensions.">
       Setting controlled by an extension
     </message>
     <message name="IDS_PAGE_INFO_PERMISSION_AUTOMATICALLY_BLOCKED" desc="The label used underneath a permission listed in the Page Info bubble if the permission was blocked by Chrome on behalf of the user.">
       Automatically blocked
     </message>
+    <message name="IDS_PAGE_INFO_PERMISSION_SUBRESOURCE_FILTER_SUBTITLE" desc="The label used underneath the subresource filter permission in the Page Info UI. Used on desktop and Android platforms" translateable="false" formatter_data="android_java">

[lgarron, 2017/05/17 20:38:11]

Could you remove the translateable="false", like with
https://codereview.chromium.org/2884813003/?

I'm not familiar with formatter_data="android_java"; does that do something
useful here?

[Charlie Harrison, 2017/05/17 20:50:13]

I don't think we should remove translateable=false for strings that are not
identical to existing strings. I was told by translation folks to add that for
placeholder strings that aren't really translateable.

formatter_data="android_java" makes it possible to share the string on Android
so it is accessible with R.string...

+       Subresource filter activated (subtitle)

[lgarron, 2017/05/17 20:38:11]

Nit: remove "(subtitle)", assuming that's meant as a placeholder.

[Charlie Harrison, 2017/05/17 20:50:13]

Done.

+    </message>
 
     <!-- Permission change infobar. -->
     <if expr="not is_android">
       <message name="IDS_PAGE_INFO_INFOBAR_TEXT" desc="The string shown in the infobar after the user has changed site permissions settings, reminding them to reload the page in order for the new settings to take effect.">
         New site permissions settings will take effect after reloading the page.
       </message>
       <message name="IDS_PAGE_INFO_INFOBAR_BUTTON" desc="The string used in the infobar button allowing the user to reload the page directly from the infobar.">
         Reload
       </message>
     </if>
 
     <!-- WebVR -->
     <message name="IDS_PAGE_INFO_INSECURE_WEBVR_CONTENT_TRANSIENT" desc="Text that is displayed temporarily as a large toast on first entering a WebVR page over non-secure transport.">
       Your connection to this site is not private. To exit VR mode at any time, remove headset and press back.
     </message>
     <message name="IDS_PAGE_INFO_INSECURE_WEBVR_CONTENT_PERMANENT" desc="Text that is displayed in a small permanent notification on a WebVR page loaded over non-secure transport. (Should be short, does not need to be a complete sentence.)">
       Not secure
     </message>
   </if>
 </grit-part>