Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: ios/chrome/browser/ui/ntp/new_tab_page_bar_button.mm

Issue 2881183002: Revert of Replace ObjCPropertyReleaser with ReleaseProperties() project-wide. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/ui/ntp/new_tab_page_bar.mm ('k') | ios/chrome/browser/ui/ntp/new_tab_page_bar_item.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/ntp/new_tab_page_bar_button.mm
diff --git a/ios/chrome/browser/ui/ntp/new_tab_page_bar_button.mm b/ios/chrome/browser/ui/ntp/new_tab_page_bar_button.mm
index 658f42560809919441d38c5a58b242d3a06fe350..91580eee51861a286585c8d684c538cea67f8275 100644
--- a/ios/chrome/browser/ui/ntp/new_tab_page_bar_button.mm
+++ b/ios/chrome/browser/ui/ntp/new_tab_page_bar_button.mm
@@ -5,7 +5,7 @@
#import "ios/chrome/browser/ui/ntp/new_tab_page_bar_button.h"
#include "base/logging.h"
-#include "base/mac/objc_release_properties.h"
+#include "base/mac/objc_property_releaser.h"
#import "ios/chrome/browser/ui/ntp/new_tab_page_bar_item.h"
#import "ios/chrome/browser/ui/uikit_ui_util.h"
#import "ios/third_party/material_components_ios/src/components/Typography/src/MaterialTypography.h"
@@ -27,6 +27,7 @@
UIImage* _image;
NSString* _title;
+ base::mac::ObjCPropertyReleaser _propertyReleaser_NewTabPageBarButton;
}
@property(nonatomic, retain) UIColor* color;
@@ -61,6 +62,8 @@
DCHECK(item.image);
NewTabPageBarButton* button =
[[self class] buttonWithType:UIButtonTypeCustom];
+ button->_propertyReleaser_NewTabPageBarButton.Init(
+ button, [NewTabPageBarButton class]);
button.title = item.title;
button.image =
@@ -80,11 +83,6 @@
[button useIncognitoColorScheme:0];
[button setContentToDisplay:new_tab_page_bar_button::ContentType::TEXT];
return button;
-}
-
-- (void)dealloc {
- base::mac::ReleaseProperties(self);
- [super dealloc];
}
- (void)useIncognitoColorScheme:(CGFloat)percentage {
« no previous file with comments | « ios/chrome/browser/ui/ntp/new_tab_page_bar.mm ('k') | ios/chrome/browser/ui/ntp/new_tab_page_bar_item.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698