Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: components/download/internal/test/test_store.cc

Issue 2881173003: Download Service : Added leveldb proto layer (Closed)
Patch Set: more comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/download/internal/test/test_store.cc
diff --git a/components/download/internal/test/test_store.cc b/components/download/internal/test/test_store.cc
index 01faec77b989ba5ae43a2329756d599ec48826a2..2236a303c8d26d542fda0e5a105be900ee00394b 100644
--- a/components/download/internal/test/test_store.cc
+++ b/components/download/internal/test/test_store.cc
@@ -18,24 +18,24 @@ bool TestStore::IsInitialized() {
return ready_;
}
-void TestStore::Initialize(InitCallback callback) {
+void TestStore::Initialize(const InitCallback& callback) {
init_called_ = true;
- init_callback_ = std::move(callback);
+ init_callback_ = callback;
}
-void TestStore::Destroy(StoreCallback callback) {
+void TestStore::Destroy(const StoreCallback& callback) {
destroy_called_ = true;
- destroy_callback_ = std::move(callback);
+ destroy_callback_ = callback;
}
-void TestStore::Update(const Entry& entry, StoreCallback callback) {
+void TestStore::Update(const Entry& entry, const StoreCallback& callback) {
updated_entries_.push_back(entry);
- update_callback_ = std::move(callback);
+ update_callback_ = callback;
}
-void TestStore::Remove(const std::string& guid, StoreCallback callback) {
+void TestStore::Remove(const std::string& guid, const StoreCallback& callback) {
removed_entries_.push_back(guid);
- remove_callback_ = std::move(callback);
+ remove_callback_ = callback;
}
// Callback trigger methods.
@@ -43,22 +43,22 @@ void TestStore::TriggerInit(bool success,
std::unique_ptr<std::vector<Entry>> entries) {
ready_ = success;
DCHECK(init_callback_);
- std::move(init_callback_).Run(success, std::move(entries));
+ init_callback_.Run(success, std::move(entries));
}
void TestStore::TriggerDestroy(bool success) {
DCHECK(destroy_callback_);
- std::move(destroy_callback_).Run(success);
+ destroy_callback_.Run(success);
}
void TestStore::TriggerUpdate(bool success) {
DCHECK(update_callback_);
- std::move(update_callback_).Run(success);
+ update_callback_.Run(success);
}
void TestStore::TriggerRemove(bool success) {
DCHECK(remove_callback_);
- std::move(remove_callback_).Run(success);
+ remove_callback_.Run(success);
}
const Entry* TestStore::LastUpdatedEntry() const {
« components/download/internal/store.h ('K') | « components/download/internal/test/test_store.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698