content/browser/browser_plugin/browser_plugin_guest.h - Issue 288113005: <webview>: Cleanup Pointer Lock & Simplify HandleKeyboardEvent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_plugin/browser_plugin_guest.h

Issue 288113005: <webview>: Cleanup Pointer Lock & Simplify HandleKeyboardEvent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed unnecessary braces Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/browser_plugin/browser_plugin_embedder.cc ('k') | content/browser/browser_plugin/browser_plugin_guest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/browser_plugin/browser_plugin_guest.h

diff --git a/content/browser/browser_plugin/browser_plugin_guest.h b/content/browser/browser_plugin/browser_plugin_guest.h

index 782816227092dfa9c82eac67210bd12001900ebd..61fea1cb080b70dd6c1bd45b64d9098ac418ea7c 100644

--- a/content/browser/browser_plugin/browser_plugin_guest.h

+++ b/content/browser/browser_plugin/browser_plugin_guest.h

@@ -105,6 +105,10 @@ class CONTENT_EXPORT BrowserPluginGuest

// Returns a WeakPtr to this BrowserPluginGuest.

base::WeakPtr<BrowserPluginGuest> AsWeakPtr();

+ // Sets the lock state of the pointer. Returns true if |allowed| is true and

+ // the mouse has been successfully locked.

+ bool LockMouse(bool allowed);

// Called when the embedder WebContents is destroyed to give the

// BrowserPluginGuest an opportunity to clean up after itself.

void EmbedderDestroyed();

@@ -140,9 +144,6 @@ class CONTENT_EXPORT BrowserPluginGuest

// Returns the BrowserPluginGuest that created this guest, if any.

BrowserPluginGuest* GetOpener() const;

- // Returns whether the mouse pointer was unlocked.

- bool UnlockMouseIfNecessary(const NativeWebKeyboardEvent& event);

void UpdateVisibility();

void CopyFromCompositingSurface(