Issue 288113005: <webview>: Cleanup Pointer Lock & Simplify HandleKeyboardEvent

Issue 288113005: <webview>: Cleanup Pointer Lock & Simplify HandleKeyboardEvent (Closed)

Created:
6 years, 7 months ago by Fady Samuel

Modified:
6 years, 7 months ago

Reviewers:
lazyboy, jabdelmalek, jam

CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, miu+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

<webview>: Cleanup Pointer Lock & Simplify HandleKeyboardEvent This CL makes BrowserPluginGuestDelegate::HandleKeyboardEvent match WebContentsDelegate::HandleKeyboardEvent. BUG=364141, 330264 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270809

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -97 lines)			Patch
M	chrome/browser/guest_view/web_view/web_view_guest.h	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/guest_view/web_view/web_view_guest.cc	View		2 chunks	+53 lines, -27 lines	0 comments	Download
M	content/browser/browser_plugin/browser_plugin_embedder.h	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	content/browser/browser_plugin/browser_plugin_embedder.cc	View		1 chunk	+0 lines, -22 lines	0 comments	Download
M	content/browser/browser_plugin/browser_plugin_guest.h	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	content/browser/browser_plugin/browser_plugin_guest.cc	View		3 chunks	+9 lines, -27 lines	0 comments	Download
M	content/browser/web_contents/web_contents_impl.cc	View	1	2 chunks	+3 lines, -5 lines	0 comments	Download
M	content/public/browser/browser_plugin_guest_delegate.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/public/browser/browser_plugin_guest_delegate.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download

Total messages: 7 (0 generated)

Fady Samuel

+jam@ for content/public and web_contents_impl.cc change +lazyboy@ for everything else Thanks!

6 years, 7 months ago (2014-05-15 15:10:47 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/288113005/10001

6 years, 7 months ago (2014-05-15 17:43:07 UTC) #6

Message was sent while issue was closed.

Change committed as 270809