[fsp] Add FileStreamReader for the reading operation.

chrome/browser/chromeos/file_system_provider/operations/read_file_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/files/file.h"
 #include "base/files/file_path.h"
-#include "base/json/json_reader.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/scoped_vector.h"
+#include "base/values.h"
 #include "chrome/browser/chromeos/file_system_provider/operations/read_file.h"
 #include "chrome/common/extensions/api/file_system_provider.h"
 #include "chrome/common/extensions/api/file_system_provider_internal.h"
 #include "extensions/browser/event_router.h"
 #include "net/base/io_buffer.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "webkit/browser/fileapi/async_file_util.h"
 
 namespace chromeos {
 namespace file_system_provider {
@@ skipping 151 matching lines @@
       kLength,
       base::Bind(&CallbackLogger::OnReadFile, callback_logger.GetWeakPtr()));
   read_file.SetDispatchEventImplForTesting(
       base::Bind(&LoggingDispatchEventImpl::OnDispatchEventImpl,
                  base::Unretained(&dispatcher)));
 
   EXPECT_FALSE(read_file.Execute(kRequestId));
 }
 
 TEST_F(FileSystemProviderOperationsReadFileTest, OnSuccess) {
-  using extensions::api::file_system_provider::EntryMetadata;
   using extensions::api::file_system_provider_internal::
       ReadFileRequestedSuccess::Params;
 
   LoggingDispatchEventImpl dispatcher(true /* dispatch_reply */);
   CallbackLogger callback_logger;
 
   ReadFile read_file(
       NULL,
       file_system_info_,
       kFileHandle,
       io_buffer_.get(),
       kOffset,
       kLength,
       base::Bind(&CallbackLogger::OnReadFile, callback_logger.GetWeakPtr()));
   read_file.SetDispatchEventImplForTesting(
       base::Bind(&LoggingDispatchEventImpl::OnDispatchEventImpl,
                  base::Unretained(&dispatcher)));
 
   EXPECT_TRUE(read_file.Execute(kRequestId));
 
-  // Sample input as JSON. Keep in sync with file_system_provider_api.idl.
-  // As for now, it is impossible to create *::Params class directly, not from
-  // base::Value.
-  const std::string input =
-      "[\n"
-      "  1,\n"          // kFileSystemId
-      "  2,\n"          // kRequestId
-      "  \"ABCDE\",\n"  // 5 bytes
-      "  false\n"       // has_next
-      "]\n";
+  const std::string data = "ABCDE";
+  const bool has_next = false;
 
-  int json_error_code;
-  std::string json_error_msg;
-  scoped_ptr<base::Value> value(base::JSONReader::ReadAndReturnError(
-      input, base::JSON_PARSE_RFC, &json_error_code, &json_error_msg));
-  ASSERT_TRUE(value.get()) << json_error_msg;
+  base::ListValue value_as_list;
+  value_as_list.Set(0, new base::FundamentalValue(kFileSystemId));
+  value_as_list.Set(1, new base::FundamentalValue(kRequestId));
+  value_as_list.Set(
+      2, base::BinaryValue::CreateWithCopiedBuffer(data.c_str(), data.size()));
+  value_as_list.Set(3, new base::FundamentalValue(has_next));
 
-  base::ListValue* value_as_list;
-  ASSERT_TRUE(value->GetAsList(&value_as_list));
-  scoped_ptr<Params> params(Params::Create(*value_as_list));
+  scoped_ptr<Params> params(Params::Create(value_as_list));
   ASSERT_TRUE(params.get());
   scoped_ptr<RequestValue> request_value(
       RequestValue::CreateForReadFileSuccess(params.Pass()));
   ASSERT_TRUE(request_value.get());
 
-  const bool has_next = false;
   read_file.OnSuccess(kRequestId, request_value.Pass(), has_next);
 
   ASSERT_EQ(1u, callback_logger.events().size());
   CallbackLogger::Event* event = callback_logger.events()[0];
   EXPECT_EQ(kLength, event->chunk_length());
   EXPECT_FALSE(event->has_next());
-  EXPECT_EQ("ABCDE", std::string(io_buffer_->data() + kOffset, kLength));
+  EXPECT_EQ(data, std::string(io_buffer_->data(), kLength));
   EXPECT_EQ(base::File::FILE_OK, event->result());
 }
 
 TEST_F(FileSystemProviderOperationsReadFileTest, OnError) {
-  using extensions::api::file_system_provider::EntryMetadata;
   using extensions::api::file_system_provider_internal::ReadFileRequestedError::
       Params;
 
   LoggingDispatchEventImpl dispatcher(true /* dispatch_reply */);
   CallbackLogger callback_logger;
 
   ReadFile read_file(
       NULL,
       file_system_info_,
       kFileHandle,
@@ skipping 10 matching lines @@
   read_file.OnError(kRequestId, base::File::FILE_ERROR_TOO_MANY_OPENED);
 
   ASSERT_EQ(1u, callback_logger.events().size());
   CallbackLogger::Event* event = callback_logger.events()[0];
   EXPECT_EQ(base::File::FILE_ERROR_TOO_MANY_OPENED, event->result());
 }
 
 }  // namespace operations
 }  // namespace file_system_provider
 }  // namespace chromeos