third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/http/tests/fetch/chromium/data-saver-expected.txt - Issue 2881073003: Support DataSaver for SharedWorker

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/virtual/off-main-thread-fetch/http/tests/fetch/chromium/data-saver-expected.txt

Issue 2881073003: Support DataSaver for SharedWorker (Closed)

Patch Set: rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/browser/shared_worker/shared_worker_instance.h ('K') | « third_party/WebKit/LayoutTests/http/tests/fetch/chromium/data-saver-expected.txt ('k') | third_party/WebKit/Source/core/exported/SharedWorkerRepositoryClientImpl.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 This is a testharness.js-based test.	1 This is a testharness.js-based test.

2 PASS fetch() from document with Data-Saver disabled.	2 PASS fetch() from document with Data-Saver disabled.

3 PASS fetch() from document with Data-Saver enabled.	3 PASS fetch() from document with Data-Saver enabled.

4 PASS fetch() from dedicated worker with Data-Saver disabled.	4 PASS fetch() from dedicated worker with Data-Saver disabled.

5 FAIL fetch() from dedicated worker with Data-Saver enabled. assert_equals: Save- Data header should be sent when enabled. method: GET expected "Save-Data: on" bu t got "No Save-Data"	5 FAIL fetch() from dedicated worker with Data-Saver enabled. assert_equals: Save- Data header should be sent when enabled. method: GET expected "Save-Data: on" bu t got "No Save-Data"

6 PASS fetch() from shared worker with Data-Saver disabled.	6 PASS fetch() from shared worker with Data-Saver disabled.

7 FAIL fetch() from shared worker with Data-Saver enabled. assert_equals: Save-Dat a header should be sent for worker script when enabled. expected "Save-Data: on" but got "No Save-Data"	7 FAIL fetch() from shared worker with Data-Saver enabled. assert_equals: Save-Dat a header should be sent when enabled. method: GET expected "Save-Data: on" but g ot "No Save-Data"
	falken 2017/05/17 00:54:53 Can you update the CL description and the bug to e Can you update the CL description and the bug to explain that this change uses the SaveData header when requesting the shared worker script, but it doesn't yet use the SaveData header for fetch() calls by the worker? horo 2017/05/17 02:15:42 Done. Show quoted text On 2017/05/17 00:54:53, falken wrote: > Can you update the CL description and the bug to explain that this change uses > the SaveData header when requesting the shared worker script, but it doesn't yet > use the SaveData header for fetch() calls by the worker? Done. horo 2017/05/17 02:22:47 Ah, I will submit https://codereview.chromium.org/ Show quoted text On 2017/05/17 02:15:42, horo wrote: > On 2017/05/17 00:54:53, falken wrote: > > Can you update the CL description and the bug to explain that this change uses > > the SaveData header when requesting the shared worker script, but it doesn't > yet > > use the SaveData header for fetch() calls by the worker? > > Done. Ah, I will submit https://codereview.chromium.org/2886663002 before this CL. So I can remove this -expected.txt file.
8 Harness: the test ran to completion.	8 Harness: the test ran to completion.

9	9

OLD	NEW