cc: Change RTree::Search to return results, add comments, more tests.

cc/paint/discardable_image_map.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/paint/discardable_image_map.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <limits>
@@ skipping 19 matching lines @@
                       [](const std::pair<DrawImage, gfx::Rect>& image) {
                         return image.second;
                       });
 }
 
 void DiscardableImageMap::GetDiscardableImagesInRect(
     const gfx::Rect& rect,
     float contents_scale,
     const gfx::ColorSpace& target_color_space,
     std::vector<DrawImage>* images) const {
-  std::vector<size_t> indices;
-  images_rtree_.Search(rect, &indices);
+  std::vector<size_t> indices = images_rtree_.Search(rect);
   for (size_t index : indices) {

[danakj, 2017/05/15 20:35:34]

you could for (.. : Search()) directly if you want

[vmpstr, 2017/05/15 20:46:33]

Done.

     images->push_back(all_images_[index]
                           .first.ApplyScale(contents_scale)
                           .ApplyTargetColorSpace(target_color_space));
   }
 }
 
 gfx::Rect DiscardableImageMap::GetRectForImage(ImageId image_id) const {
   const auto& it = image_id_to_rect_.find(image_id);
   return it == image_id_to_rect_.end() ? gfx::Rect() : it->second;
 }
 
 DiscardableImageMap::ScopedMetadataGenerator::ScopedMetadataGenerator(
     DiscardableImageMap* image_map,
     const gfx::Size& bounds)
     : image_map_(image_map),
       image_store_(image_map->BeginGeneratingMetadata(bounds)) {}
 
 DiscardableImageMap::ScopedMetadataGenerator::~ScopedMetadataGenerator() {
   image_map_->EndGeneratingMetadata();
 }
 
 }  // namespace cc