Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2881053002: Add support for super constructor invocation (Closed)

Created:
3 years, 7 months ago by zhivkag
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Apply comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -8 lines) Patch
M pkg/kernel/lib/interpreter/interpreter.dart View 1 5 chunks +40 lines, -8 lines 0 comments Download
A pkg/kernel/testcases/interpreter/object_super_test.dart View 1 chunk +40 lines, -0 lines 0 comments Download
A pkg/kernel/testcases/interpreter/object_super_test.dart.expect View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
zhivkag
Hi, This change adds support for super calls in constructor invocations. It assumes the super ...
3 years, 7 months ago (2017-05-15 11:26:53 UTC) #2
Dmitry Stefantsov
LGTM with a small question. https://codereview.chromium.org/2881053002/diff/1/pkg/kernel/lib/interpreter/interpreter.dart File pkg/kernel/lib/interpreter/interpreter.dart (right): https://codereview.chromium.org/2881053002/diff/1/pkg/kernel/lib/interpreter/interpreter.dart#newcode657 pkg/kernel/lib/interpreter/interpreter.dart:657: return new ContinuationConfiguration(continuation, newObject); ...
3 years, 7 months ago (2017-05-15 11:48:23 UTC) #3
zhivkag
https://codereview.chromium.org/2881053002/diff/1/pkg/kernel/lib/interpreter/interpreter.dart File pkg/kernel/lib/interpreter/interpreter.dart (right): https://codereview.chromium.org/2881053002/diff/1/pkg/kernel/lib/interpreter/interpreter.dart#newcode657 pkg/kernel/lib/interpreter/interpreter.dart:657: return new ContinuationConfiguration(continuation, newObject); On 2017/05/15 11:48:23, Dmitry Stefantsov ...
3 years, 7 months ago (2017-05-15 11:58:14 UTC) #4
zhivkag
3 years, 7 months ago (2017-05-15 11:58:53 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
614f9207b60be580761a867bfa5ee41a6fe47a7e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698