media/cast/video_receiver/video_decoder.h - Issue 288103002: [Cast] EncodedAudioFrame+EncodedVideoFrame+reference_time --> EncodedFrame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/cast/video_receiver/video_decoder.h

Issue 288103002: [Cast] EncodedAudioFrame+EncodedVideoFrame+reference_time --> EncodedFrame (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed hclam@'s first round comments. Fixed chrome unit_tests compiles. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« media/cast/transport/cast_transport_config.h ('K') | « media/cast/video_receiver/codecs/vp8/vp8_decoder.h ('k') | media/cast/video_receiver/video_decoder.cc » ('j') | media/cast/video_sender/codecs/vp8/vp8_encoder.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/cast/video_receiver/video_decoder.h

diff --git a/media/cast/video_receiver/video_decoder.h b/media/cast/video_receiver/video_decoder.h

index 7f0db54aa8d684029c53300301787359a5453c1b..d8a3b7ed68f9a11b7795783aa03352cf088a0cd9 100644

--- a/media/cast/video_receiver/video_decoder.h

+++ b/media/cast/video_receiver/video_decoder.h

@@ -43,7 +43,8 @@ class VideoDecoder {

// monotonically-increasing by 1 for each successive call to this method.

// When it is not, the decoder will assume one or more frames have been

// dropped (e.g., due to packet loss), and will perform recovery actions.

- void DecodeFrame(scoped_ptr<transport::EncodedVideoFrame> encoded_frame,

+ // TODO(miu): FIXME: This assumption will break VP8 3-buffer mode.

hubbe 2014/05/16 17:13:20 ?

miu 2014/05/16 21:28:46 Done. Oops, nothing to see here...

+ void DecodeFrame(scoped_ptr<transport::EncodedFrame> encoded_frame,

const DecodeFrameCallback& callback);

private: