net/data/parse_certificate_unittest/serial_negative.pem - Issue 2881023003: X509CertificateBytes: Allow invalid serial numbers for now.

Unified Diff: net/data/parse_certificate_unittest/serial_negative.pem

Issue 2881023003: X509CertificateBytes: Allow invalid serial numbers for now. (Closed)

Patch Set: remove excess whitespace Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« net/cert/x509_certificate_unittest.cc ('K') | « net/data/parse_certificate_unittest/serial_37_bytes.pem ('k') | net/data/parse_certificate_unittest/serial_zero_padded.pem » ('j') | net/data/parse_certificate_unittest/serial_zero_padded.pem » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/data/parse_certificate_unittest/serial_negative.pem

diff --git a/net/data/parse_certificate_unittest/serial_negative.pem b/net/data/parse_certificate_unittest/serial_negative.pem

new file mode 100644

index 0000000000000000000000000000000000000000..1570ab27129db7ae78fd46595e1799f5c99aad90

--- /dev/null

+++ b/net/data/parse_certificate_unittest/serial_negative.pem

@@ -0,0 +1,12 @@

+This cert has an invalid serial number which is negative.

eroman 2017/05/15 22:42:10 At the risk of causing you more work, we have some

mattm 2017/05/15 23:16:44 Did you want to remove the ones from parse_certifi

eroman 2017/05/15 23:56:47 My main motivation is to not duplicate similar .pe

mattm 2017/05/16 00:33:57 Done.

+The certificate data can be updated/regenerated with the

+net/data/parse_certificate_unittest/regenerate_pem_from_ascii.py script.

+#-----BEGIN SERIAL-----

+ INTEGER { `8001` }

+#-----END SERIAL-----

+-----BEGIN CERTIFICATE-----

+MIICUTCCAbqgAwIBAgICgAEwDQYJKoZIhvcNAQEFBQAwRTELMAkGA1UEBhMCQVUxEzARBgNVBAgMClNvbWUtU3RhdGUxITAfBgNVBAoMGEludGVybmV0IFdpZGdpdHMgUHR5IEx0ZDAeFw0xNDA0MjMyMDUwNDBaFw0xNzA0MjIyMDUwNDBaMEUxCzAJBgNVBAYTAkFVMRMwEQYDVQQIDApTb21lLVN0YXRlMSEwHwYDVQQKDBhJbnRlcm5ldCBXaWRnaXRzIFB0eSBMdGQwgZ8wDQYJKoZIhvcNAQEBBQADgY0AMIGJAoGBANgryKYy5GL/TfPQrVmLRae98Ue/CVh7Ir01rpclhpSggMC0H3aRZ0Yx0BCEtyIecCORcsjpbXk6hXeAD8SVFnXFSnFMyGM/o/JjnCpPmvrLwXFuKIUooCceZRyuB9Vbby1D7SuQsYyvJG2u6Rc6BcG/uByuZTsbWMLZrtaqZ4jxAgMBAAGjUDBOMB0GA1UdDgQWBBSLddWsywi+Dh9lt/pWvmynddqFrzAfBgNVHSMEGDAWgBSLddWsywi+Dh9lt/pWvmynddqFrzAMBgNVHRMEBTADAQH/MA0GCSqGSIb3DQEBBQUAA4GBADvoeG2V1j1q9xMZLBvCiK4iq/SNMvV8cWfPLdEcwsOH4um+iVzkNKtIkcI/la4rR54leGtPmhCkcv3P9wIMsAoIpFri5XR+ER05YGrJH2nzLmMm3J7va3oK4VRXmKpykXgEfh+PZU0fCxKsnCQPhBQaVS0fu/CdCbIIXFkyZYAm

+-----END CERTIFICATE-----