Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(640)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: net/data/parse_certificate_unittest/serial_37_bytes.pem
Issue
2881023003
:
X509CertificateBytes: Allow invalid serial numbers for now. (Closed)
Patch Set: remove excess whitespace
Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
net/cert/x509_certificate_bytes.cc
net/cert/x509_certificate_unittest.cc
net/data/parse_certificate_unittest/serial_37_bytes.pem
net/data/parse_certificate_unittest/serial_negative.pem
net/data/parse_certificate_unittest/serial_zero_padded.pem
net/data/parse_certificate_unittest/serial_zero_padded_21_bytes.pem
net/data/parse_certificate_unittest/v3_certificate_template.txt
View unified diff
|
Download patch
« net/cert/x509_certificate_unittest.cc
('K') |
« net/cert/x509_certificate_unittest.cc
('k') |
net/data/parse_certificate_unittest/serial_negative.pem »
('j') |
net/data/parse_certificate_unittest/serial_negative.pem »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
This cert has an invalid serial number which has is 37 bytes long (should be
2
<=20 bytes long).
3
4
The certificate data can be updated/regenerated with the
5
net/data/parse_certificate_unittest/regenerate_pem_from_ascii.py script.
6
7
#-----BEGIN SERIAL-----
8
INTEGER { `0102030405060708090a0b0c0d0e0f101112131415161718191a1b1c1d1e1f202 122232425` }
9
#-----END SERIAL-----
10
11
-----BEGIN CERTIFICATE-----
12
MIICdDCCAd2gAwIBAgIlAQIDBAUGBwgJCgsMDQ4PEBESExQVFhcYGRobHB0eHyAhIiMkJTANBgkqhkiG 9w0BAQUFADBFMQswCQYDVQQGEwJBVTETMBEGA1UECAwKU29tZS1TdGF0ZTEhMB8GA1UECgwYSW50ZXJu ZXQgV2lkZ2l0cyBQdHkgTHRkMB4XDTE0MDQyMzIwNTA0MFoXDTE3MDQyMjIwNTA0MFowRTELMAkGA1UE BhMCQVUxEzARBgNVBAgMClNvbWUtU3RhdGUxITAfBgNVBAoMGEludGVybmV0IFdpZGdpdHMgUHR5IEx0 ZDCBnzANBgkqhkiG9w0BAQEFAAOBjQAwgYkCgYEA2CvIpjLkYv9N89CtWYtFp73xR78JWHsivTWulyWG lKCAwLQfdpFnRjHQEIS3Ih5wI5FyyOlteTqFd4APxJUWdcVKcUzIYz+j8mOcKk+a+svBcW4ohSigJx5l HK4H1VtvLUPtK5CxjK8kba7pFzoFwb+4HK5lOxtYwtmu1qpniPECAwEAAaNQME4wHQYDVR0OBBYEFIt1 1azLCL4OH2W3+la+bKd12oWvMB8GA1UdIwQYMBaAFIt11azLCL4OH2W3+la+bKd12oWvMAwGA1UdEwQF MAMBAf8wDQYJKoZIhvcNAQEFBQADgYEAO+h4bZXWPWr3ExksG8KIriKr9I0y9XxxZ88t0RzCw4fi6b6J XOQ0q0iRwj+VritHniV4a0+aEKRy/c/3AgywCgikWuLldH4RHTlgaskfafMuYybcnu9regrhVFeYqnKR eAR+H49lTR8LEqycJA+EFBpVLR+78J0JsghcWTJlgCY=
13
-----END CERTIFICATE-----
OLD
NEW
« net/cert/x509_certificate_unittest.cc
('K') |
« net/cert/x509_certificate_unittest.cc
('k') |
net/data/parse_certificate_unittest/serial_negative.pem »
('j') |
net/data/parse_certificate_unittest/serial_negative.pem »
('J')
Issue 2881023003: X509CertificateBytes: Allow invalid serial numbers for now. (Closed)
Created 3 years, 7 months ago by mattm
Modified 3 years, 7 months ago
Reviewers: eroman
Base URL:
Comments: 10
This is Rietveld
408576698