Move FrameSelection::CurrentForm() to ContextMenuClientImpl

third_party/WebKit/Source/web/ContextMenuClientImpl.cpp

 /*
  * Copyright (C) 2009, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 18 matching lines @@
  */
 
 #include "web/ContextMenuClientImpl.h"
 
 #include "bindings/core/v8/ExceptionState.h"
 #include "core/CSSPropertyNames.h"
 #include "core/HTMLNames.h"
 #include "core/InputTypeNames.h"
 #include "core/css/CSSStyleDeclaration.h"
 #include "core/dom/Document.h"
+#include "core/dom/ElementTraversal.h"
 #include "core/editing/Editor.h"
 #include "core/editing/markers/DocumentMarkerController.h"
 #include "core/editing/spellcheck/SpellChecker.h"
 #include "core/exported/WebDataSourceImpl.h"
 #include "core/exported/WebViewBase.h"
 #include "core/frame/FrameView.h"
 #include "core/frame/Settings.h"
 #include "core/frame/VisualViewport.h"
 #include "core/frame/WebLocalFrameBase.h"
 #include "core/html/HTMLAnchorElement.h"
 #include "core/html/HTMLFormElement.h"
+#include "core/html/HTMLFrameElementBase.h"
 #include "core/html/HTMLImageElement.h"
 #include "core/html/HTMLInputElement.h"
 #include "core/html/HTMLMediaElement.h"
 #include "core/html/HTMLPlugInElement.h"
 #include "core/input/EventHandler.h"
 #include "core/layout/HitTestResult.h"
 #include "core/layout/LayoutPart.h"
 #include "core/loader/DocumentLoader.h"
 #include "core/loader/FrameLoader.h"
 #include "core/loader/HistoryItem.h"
@@ skipping 131 matching lines @@
     const WebContextMenuData& data) {
   return web_view_->GetPage()
              ->GetSettings()
              .GetAlwaysShowContextMenuOnTouch() ||
          !data.link_url.IsEmpty() ||
          data.media_type == WebContextMenuData::kMediaTypeImage ||
          data.media_type == WebContextMenuData::kMediaTypeVideo ||
          data.is_editable;
 }
 
+static inline HTMLFormElement* AssociatedFormElement(HTMLElement& element) {

[yosin_UTC9, 2017/05/16 09:57:33]

nit: s/inline //

[tanvir, 2017/05/16 13:40:26]

Done.

+  if (isHTMLFormElement(element))
+    return &toHTMLFormElement(element);
+  return element.formOwner();
+}
+
+// Scans logically forward from "start", including any child frames.
+static HTMLFormElement* ScanForForm(Node* start) {
+  if (!start)
+    return 0;

[yosin_UTC9, 2017/05/16 09:57:33]

nit: s/0/nullptr/

[tanvir, 2017/05/16 13:40:26]

Done.

+
+  for (HTMLElement& element : Traversal<HTMLElement>::StartsAt(
+           start->IsHTMLElement() ? ToHTMLElement(start)
+                                  : Traversal<HTMLElement>::Next(*start))) {
+    if (HTMLFormElement* form = AssociatedFormElement(element))
+      return form;
+
+    if (IsHTMLFrameElementBase(element)) {
+      Node* child_document = ToHTMLFrameElementBase(element).contentDocument();
+      if (HTMLFormElement* frame_result = ScanForForm(child_document))
+        return frame_result;
+    }
+  }
+  return 0;

[yosin_UTC9, 2017/05/16 09:57:33]

nit: s/0/nullptr/

[tanvir, 2017/05/16 13:40:26]

Done.

[tanvir, 2017/05/16 13:40:26]

Done.

+}
+
+// We look for either the form containing the current focus, or for one
+// immediately after it
+static HTMLFormElement* CurrentForm(const FrameSelection& current_selection) {
+  // Start looking either at the active (first responder) node, or where the
+  // selection is.
+  Node* start = current_selection.GetDocument().FocusedElement();

[yosin_UTC9, 2017/05/16 09:57:33]

nit: s/Node*/Node* const/

[tanvir, 2017/05/16 13:40:26]

We are assigning value below to start when !start. 

+  if (!start) {
+    start = current_selection.ComputeVisibleSelectionInDOMTree()
+                .Start()
+                .AnchorNode();
+  }
+  if (!start)
+    return 0;

[yosin_UTC9, 2017/05/16 09:57:33]

nit: s/0/nullptr/

[tanvir, 2017/05/16 13:40:26]

Done.

+
+  // Try walking up the node tree to find a form element.
+  for (HTMLElement* element =

[yosin_UTC9, 2017/05/16 09:57:33]

Let's use NodeTraversal::InclusiveAncestorsOf() to use range-for.
We could write:

for (Node& node : NodeTraversal::InclusiveAncestorsOf(*start)) {
  if (!isHTMLElement(node))
    break;
  const HTMLElement& element = toHTMLElement(node);
  ....
}

[tanvir, 2017/05/16 13:40:26]

done. here also const not added as because of line num 205,
"return &toHTMLFormElement(element);" 

+           Traversal<HTMLElement>::FirstAncestorOrSelf(*start);
+       element; element = Traversal<HTMLElement>::FirstAncestor(*element)) {
+    if (HTMLFormElement* form = AssociatedFormElement(*element))
+      return form;
+  }
+
+  // Try walking forward in the node tree to find a form element.
+  return ScanForForm(start);
+}
+
 bool ContextMenuClientImpl::ShowContextMenu(const ContextMenu* default_menu,
                                             bool from_touch) {
   // Displaying the context menu in this function is a big hack as we don't
   // have context, i.e. whether this is being invoked via a script or in
   // response to user input (Mouse event WM_RBUTTONDOWN,
   // Keyboard events KeyVK_APPS, Shift+F10). Check if this is being invoked
   // in response to the above input events before popping up the context menu.
   if (!ContextMenuAllowedScope::IsContextMenuAllowed())
     return false;
 
@@ skipping 157 matching lines @@
       Vector<String> suggestions;
       description.Split('\n', suggestions);
       data.dictionary_suggestions = suggestions;
     } else if (selected_web_frame->TextCheckClient()) {
       int misspelled_offset, misspelled_length;
       selected_web_frame->TextCheckClient()->CheckSpelling(
           data.misspelled_word, misspelled_offset, misspelled_length,
           &data.dictionary_suggestions);
     }
 
-    HTMLFormElement* form = selected_frame->Selection().CurrentForm();
+    HTMLFormElement* form = CurrentForm(selected_frame->Selection());
     if (form && isHTMLInputElement(*r.InnerNode())) {
       HTMLInputElement& selected_element = toHTMLInputElement(*r.InnerNode());
       WebSearchableFormData ws = WebSearchableFormData(
           WebFormElement(form), WebInputElement(&selected_element));
       if (ws.Url().IsValid())
         data.keyword_url = ws.Url();
     }
   }
 
   if (selected_frame->GetEditor().SelectionHasStyle(CSSPropertyDirection,
@@ skipping 115 matching lines @@
   sub_menu_items.Swap(output_items);
 }
 
 void ContextMenuClientImpl::PopulateCustomMenuItems(
     const ContextMenu* default_menu,
     WebContextMenuData* data) {
   PopulateSubMenuItems(default_menu->Items(), data->custom_items);
 }
 
 }  // namespace blink