Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 2881013002: Remove ScopedVector from all other codes in media/ (Closed)

Created:
3 years, 7 months ago by xiaofengzhang
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, mfoltz+watch_chromium.org, qsr+mojo_chromium.org, toyoshim+midi_chromium.org, feature-media-reviews_chromium.org, posciak+watch_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, miu+watch_chromium.org, eme-reviews_chromium.org, darin-cc_chromium.org, apacible+watch_chromium.org, alokp+watch_chromium.org, piman+watch_chromium.org, darin (slow to review), erickung+watch_chromium.org, xjz+watch_chromium.org, Aaron Boodman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ScopedVector from all other codes in media/ base::ScopedVector is deprecated, see bug. BUG=554289, 588249

Patch Set 1 : Remove ScopedVector from all other codes in media/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -110 lines) Patch
M chromecast/media/cdm/cast_cdm.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M content/renderer/pepper/content_decryptor_delegate.cc View 2 chunks +2 lines, -1 line 0 comments Download
M media/base/android/media_drm_bridge.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/base/content_decryption_module.h View 2 chunks +1 line, -2 lines 0 comments Download
M media/blink/cdm_session_adapter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/blink/webcontentdecryptionmodulesession_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cdm/aes_decryptor.cc View 2 chunks +3 lines, -1 line 0 comments Download
M media/cdm/aes_decryptor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cdm/cdm_adapter.cc View 2 chunks +2 lines, -1 line 0 comments Download
M media/cdm/ppapi/external_clear_key/clear_key_cdm.cc View 3 chunks +12 lines, -2 lines 0 comments Download
M media/formats/webm/opus_packet_builder.h View 2 chunks +1 line, -2 lines 0 comments Download
M media/formats/webm/opus_packet_builder.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M media/formats/webm/webm_cluster_parser_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/gpu/jpeg_decode_accelerator_unittest.cc View 7 chunks +12 lines, -10 lines 0 comments Download
M media/gpu/video_encode_accelerator_unittest.cc View 12 chunks +23 lines, -21 lines 0 comments Download
M media/midi/midi_device_android.h View 3 chunks +8 lines, -5 lines 0 comments Download
M media/midi/midi_device_android.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M media/midi/midi_manager_android.h View 2 chunks +1 line, -2 lines 0 comments Download
M media/midi/midi_manager_android.cc View 3 chunks +16 lines, -14 lines 0 comments Download
M media/midi/midi_manager_unittest.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M media/midi/midi_manager_usb.h View 2 chunks +4 lines, -3 lines 0 comments Download
M media/midi/midi_manager_usb.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M media/midi/midi_manager_usb_unittest.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M media/midi/usb_midi_device.h View 2 chunks +1 line, -2 lines 0 comments Download
M media/midi/usb_midi_device_factory_android.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M media/mojo/clients/mojo_cdm.cc View 1 chunk +1 line, -2 lines 0 comments Download
M media/mojo/services/mojo_cdm_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/remoting/proto_utils.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 31 (31 generated)
xiaofengzhang
Description was changed from ========== Remove ScopedVector from all other codes in media/ base::ScopedVector is ...
3 years, 7 months ago (2017-05-15 07:54:45 UTC) #1
xiaofengzhang
The CQ bit was checked by xiaofeng.zhang@intel.com to run a CQ dry run
3 years, 7 months ago (2017-05-15 07:57:10 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2881013002/1
3 years, 7 months ago (2017-05-15 07:57:26 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-15 08:10:34 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/453266)
3 years, 7 months ago (2017-05-15 08:10:35 UTC) #5
xiaofengzhang
The CQ bit was checked by xiaofeng.zhang@intel.com to run a CQ dry run
3 years, 7 months ago (2017-05-15 09:11:25 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2881013002/20001
3 years, 7 months ago (2017-05-15 09:11:37 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-15 09:24:27 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/267755) chromeos_daisy_chromium_compile_only_ng on ...
3 years, 7 months ago (2017-05-15 09:24:28 UTC) #9
xiaofengzhang
The CQ bit was checked by xiaofeng.zhang@intel.com to run a CQ dry run
3 years, 7 months ago (2017-05-15 15:18:47 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2881013002/40001
3 years, 7 months ago (2017-05-15 15:19:24 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-15 15:34:29 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/339417) chromeos_daisy_chromium_compile_only_ng on ...
3 years, 7 months ago (2017-05-15 15:34:30 UTC) #13
xiaofengzhang
Patchset #1 (id:1) has been deleted
3 years, 7 months ago (2017-05-17 02:05:21 UTC) #14
xiaofengzhang
Patchset #1 (id:20001) has been deleted
3 years, 7 months ago (2017-05-17 02:05:34 UTC) #15
xiaofengzhang
Patchset #1 (id:40001) has been deleted
3 years, 7 months ago (2017-05-17 02:05:45 UTC) #16
xiaofengzhang
Patchset #1 (id:60001) has been deleted
3 years, 7 months ago (2017-05-17 02:05:59 UTC) #17
xiaofengzhang
The CQ bit was checked by xiaofeng.zhang@intel.com to run a CQ dry run
3 years, 7 months ago (2017-05-17 02:18:30 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2881013002/100001
3 years, 7 months ago (2017-05-17 02:20:19 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-17 04:00:09 UTC) #20
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/456828)
3 years, 7 months ago (2017-05-17 04:00:10 UTC) #21
xiaofengzhang
The CQ bit was checked by xiaofeng.zhang@intel.com to run a CQ dry run
3 years, 7 months ago (2017-05-17 04:21:02 UTC) #22
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2881013002/100001
3 years, 7 months ago (2017-05-17 04:21:49 UTC) #23
xiaofengzhang
Patchset #1 (id:80001) has been deleted
3 years, 7 months ago (2017-05-17 04:32:52 UTC) #24
xiaofengzhang
Description was changed from ========== Remove ScopedVector from all other codes in media/ base::ScopedVector is ...
3 years, 7 months ago (2017-05-17 04:33:47 UTC) #25
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-17 06:21:18 UTC) #26
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/456982)
3 years, 7 months ago (2017-05-17 06:21:19 UTC) #27
xiaofengzhang
The CQ bit was checked by xiaofeng.zhang@intel.com to run a CQ dry run
3 years, 7 months ago (2017-05-17 07:01:03 UTC) #28
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2881013002/100001
3 years, 7 months ago (2017-05-17 07:01:40 UTC) #29
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-17 09:25:49 UTC) #30
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 09:25:51 UTC) #31
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698