third_party/WebKit/Source/core/style/StyleRareInheritedData.h - Issue 2881003002: Cleanup StyleRareInheritedData.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/style/StyleRareInheritedData.h

Issue 2881003002: Cleanup StyleRareInheritedData. (Closed)

Patch Set: Rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/style/StyleRareInheritedData.cpp » ('j') | third_party/WebKit/Source/core/style/StyleRareInheritedData.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/style/StyleRareInheritedData.h

diff --git a/third_party/WebKit/Source/core/style/StyleRareInheritedData.h b/third_party/WebKit/Source/core/style/StyleRareInheritedData.h

index ca3f63ba55d1bec8a5ae5e10052b72a957d2d41f..16d27b158982c556228641a6dc6df0ae84aef76e 100644

--- a/third_party/WebKit/Source/core/style/StyleRareInheritedData.h

+++ b/third_party/WebKit/Source/core/style/StyleRareInheritedData.h

@@ -28,8 +28,15 @@

#include "core/CoreExport.h"

#include "core/css/StyleAutoColor.h"

#include "core/css/StyleColor.h"

+#include "core/style/AppliedTextDecoration.h"

#include "core/style/AppliedTextDecorationList.h"

+#include "core/style/CursorData.h"

#include "core/style/CursorList.h"

+#include "core/style/QuotesData.h"

+#include "core/style/ShadowData.h"

+#include "core/style/ShadowList.h"

+#include "core/style/StyleImage.h"

+#include "core/style/StyleInheritedVariables.h"

#include "core/style/TextSizeAdjust.h"

#include "platform/Length.h"

#include "platform/graphics/Color.h"

@@ -54,7 +61,7 @@ class StyleInheritedVariables;

// all methods on it, merging them into copy/creation methods on ComputedStyle

// instead. Keep the allocation logic, only allocating a new object if needed.

class CORE_EXPORT StyleRareInheritedData

- : public RefCounted<StyleRareInheritedData> {

+ : public RefCountedCopyable<StyleRareInheritedData> {

public:

static PassRefPtr<StyleRareInheritedData> Create() {

return AdoptRef(new StyleRareInheritedData);

@@ -62,7 +69,6 @@ class CORE_EXPORT StyleRareInheritedData

PassRefPtr<StyleRareInheritedData> Copy() const {

return AdoptRef(new StyleRareInheritedData(*this));

}

- ~StyleRareInheritedData();

bool operator==(const StyleRareInheritedData&) const;

bool operator!=(const StyleRareInheritedData& o) const {

@@ -164,7 +170,7 @@ class CORE_EXPORT StyleRareInheritedData

private:

StyleRareInheritedData();

- StyleRareInheritedData(const StyleRareInheritedData&);

+ StyleRareInheritedData(const StyleRareInheritedData&) = default;

alancutter (OOO until 2018) 2017/05/16 06:24:35 Can = default be used in CPP files? Perhaps it's b

};

} // namespace blink