Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Side by Side Diff: third_party/WebKit/Source/core/dom/AXObjectCacheBase.h

Issue 2880993002: Introduce AXObjectCacheBase in core/ and remove WebNode dependency (Closed)
Patch Set: More review feedback Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef AXObjectCacheBase_h
6 #define AXObjectCacheBase_h
7
8 #include "core/CoreExport.h"
9 #include "core/dom/AXObjectCache.h"
10
11 namespace blink {
12
13 class Node;
14 class AXObjectImpl;
15
16 // AXObjectCacheBase is a temporary class that sits between AXObjectCache and
17 // AXObjectImpl and contains methods required by web/ that we don't want to be
18 // available in the public API (AXObjectCache).
19 // TODO(dmazzoni): Once all dependencies in web/ use this class instead of
20 // AXObjectCacheImpl, refactor usages to use AXObjectCache instead (introducing
21 // new public API methods or similar) and remove this class.
22 class CORE_EXPORT AXObjectCacheBase : public AXObjectCache {
23 WTF_MAKE_NONCOPYABLE(AXObjectCacheBase);
24
25 public:
26 virtual ~AXObjectCacheBase() {}
27
28 virtual AXObjectImpl* Get(Node*) = 0;
dmazzoni 2017/05/15 20:45:10 Just checking, but this will eventually only retur
sashab 2017/05/16 00:10:02 Yes :) Was going to put a TODO but it will happen
29
30 protected:
31 AXObjectCacheBase() {}
32 };
33
34 // This is the only subclass of AXObjectCache.
35 DEFINE_TYPE_CASTS(AXObjectCacheBase, AXObjectCache, cache, true, true);
36
37 } // namespace blink
38
39 #endif
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698