Introduce AXObjectCacheBase in core/ and remove WebNode dependency

third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.h

 /*
  * Copyright (C) 2014, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 12 matching lines @@
  * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
  * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
  * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef AXObjectCacheImpl_h
 #define AXObjectCacheImpl_h
 
 #include <memory>
-#include "core/dom/AXObjectCache.h"
+#include "core/dom/AXObjectCacheBase.h"
 #include "modules/ModulesExport.h"
 #include "modules/accessibility/AXObject.h"
 #include "platform/wtf/Forward.h"
 #include "platform/wtf/HashMap.h"
 #include "platform/wtf/HashSet.h"
 
 namespace blink {
 
 class AbstractInlineTextBox;
 class HTMLAreaElement;
 class FrameView;
 
 // This class should only be used from inside the accessibility directory.
-class MODULES_EXPORT AXObjectCacheImpl : public AXObjectCache {
+class MODULES_EXPORT AXObjectCacheImpl : public AXObjectCacheBase {
   WTF_MAKE_NONCOPYABLE(AXObjectCacheImpl);
 
  public:
   static AXObjectCache* Create(Document&);
 
   explicit AXObjectCacheImpl(Document&);
   ~AXObjectCacheImpl();

[slangley, 2017/05/15 05:27:20]

doesn't this need an override?

   DECLARE_VIRTUAL_TRACE();
 
   AXObject* FocusedObject();
 
   void Dispose() override;
 
   void SelectionChanged(Node*) override;
   void ChildrenChanged(Node*) override;
   void ChildrenChanged(LayoutObject*) override;
   void CheckedStateChanged(Node*) override;
@@ skipping 56 matching lines @@
   AXObject* ObjectFromAXID(AXID id) const { return objects_.at(id); }
   AXObject* Root();
 
   // used for objects without backing elements
   AXObject* GetOrCreate(AccessibilityRole);
   AXObject* GetOrCreate(LayoutObject*);
   AXObject* GetOrCreate(Node*);
   AXObject* GetOrCreate(AbstractInlineTextBox*);
 
   // will only return the AXObject if it already exists
-  AXObject* Get(Node*);
+  AXObject* Get(Node*) override;
   AXObject* Get(LayoutObject*);
   AXObject* Get(AbstractInlineTextBox*);
 
   AXObject* FirstAccessibleObjectFromNode(const Node*);
 
   void Remove(AXID);
 
   void ChildrenChanged(AXObject*);
 
   void HandleActiveDescendantChanged(Node*);
@@ skipping 118 matching lines @@
 // This is the only subclass of AXObjectCache.
 DEFINE_TYPE_CASTS(AXObjectCacheImpl, AXObjectCache, cache, true, true);
 
 bool NodeHasRole(Node*, const String& role);
 // This will let you know if aria-hidden was explicitly set to false.
 bool IsNodeAriaVisible(Node*);
 
 }  // namespace blink
 
 #endif