Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Issue 2880953003: [subresource_filter] Revamp Site Details page (Closed)

Created:
3 years, 7 months ago by Charlie Harrison
Modified:
3 years, 7 months ago
Reviewers:
raymes
CC:
chromium-reviews, srahim+watch_chromium.org, subresource-filter-reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[subresource_filter] Revamp Site Details page The subresource filter site details page has a few custom requirements. - Allow and Block strings have two variants, active and passive. Which one to use depends on whether the site is currently activated for subresource filtering. - The radio dialog always uses the passive strings These constraints led to the creation of a ChromeBaseListPreference subclass that changes its underlying string entries dynamically based on activation and whether the radio dialog is showing. BUG=689487

Patch Set 1 #

Messages

Total messages: 8 (6 generated)
Charlie Harrison
raymes: This is the most substantial of the settings UI changes. No tests yet but ...
3 years, 7 months ago (2017-05-15 02:53:21 UTC) #4
Charlie Harrison
3 years, 7 months ago (2017-05-15 15:18:09 UTC) #7
We decided not to go this route.

I'm closing this issue instead of modifying it for posterity, because someone
(maybe us) might want to do this in the future and this will be a nice template
of a solution.

Powered by Google App Engine
This is Rietveld 408576698