Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: content/browser/download/download_item_impl.cc

Issue 2880933002: Download driver for components/download. (Closed)
Patch Set: Polish manager logic. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/download_item_impl.cc
diff --git a/content/browser/download/download_item_impl.cc b/content/browser/download/download_item_impl.cc
index 1132560218034b46a8b1e4f9f82f8c51bc726877..dccaf11c8316d5e1404abdaf6889485d04ec6bb9 100644
--- a/content/browser/download/download_item_impl.cc
+++ b/content/browser/download/download_item_impl.cc
@@ -203,7 +203,8 @@ DownloadItemImpl::DownloadItemImpl(DownloadItemImplDelegate* delegate,
uint32_t download_id,
const DownloadCreateInfo& info,
const net::NetLogWithSource& net_log)
- : guid_(base::ToUpperASCII(base::GenerateGUID())),
+ : guid_(info.guid.empty() ? base::ToUpperASCII(base::GenerateGUID())
qinmin 2017/05/23 04:21:24 will this download item be written to the history
xingliu 2017/05/23 16:56:13 I think this logic happens before writing to histo
qinmin 2017/05/23 18:12:17 Sorry, what I am saying is that why not let Downlo
+ : info.guid),
download_id_(download_id),
target_disposition_((info.save_info->prompt_for_save_location)
? TARGET_DISPOSITION_PROMPT

Powered by Google App Engine
This is Rietveld 408576698