Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 288083002: linux_aura: Reenable a bunch of tests that were disabled. (Closed)

Created:
6 years, 7 months ago by Elliot Glaysher
Modified:
6 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, extensions-reviews_chromium.org, jennb, tfarina, Dmitry Titov, jianli, dcheng, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

linux_aura: Reenable a bunch of tests that were disabled. BUG=163931 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270892

Patch Set 1 #

Patch Set 2 : Hopefully telematry tests have been fixed on ToT yet? #

Patch Set 3 : Reupload. (Hopefully the trybots won't crash during re2c this time.) #

Patch Set 4 : Revert the BookmarkBarView test enabling; those are still failing. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -83 lines) Patch
M chrome/browser/extensions/extension_fullscreen_apitest.cc View 3 chunks +3 lines, -23 lines 0 comments Download
M chrome/browser/extensions/extension_keybinding_apitest.cc View 1 chunk +2 lines, -16 lines 0 comments Download
M chrome/browser/extensions/extension_url_rewrite_browsertest.cc View 1 chunk +1 line, -7 lines 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 3 chunks +3 lines, -21 lines 0 comments Download
M chrome/browser/ui/panels/base_panel_browser_test.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/web_dialog_view_browsertest.cc View 1 chunk +1 line, -8 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
Elliot Glaysher
Working through tests that were fixed in the interim. https://codereview.chromium.org/288083002/diff/60001/chrome/browser/ui/views/web_dialog_view_browsertest.cc File chrome/browser/ui/views/web_dialog_view_browsertest.cc (right): https://codereview.chromium.org/288083002/diff/60001/chrome/browser/ui/views/web_dialog_view_browsertest.cc#newcode92 chrome/browser/ui/views/web_dialog_view_browsertest.cc:92: ...
6 years, 7 months ago (2014-05-15 22:35:48 UTC) #1
sky
LGTM
6 years, 7 months ago (2014-05-15 22:53:11 UTC) #2
Elliot Glaysher
The CQ bit was checked by erg@chromium.org
6 years, 7 months ago (2014-05-15 22:55:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/288083002/60001
6 years, 7 months ago (2014-05-15 22:56:38 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-16 01:32:48 UTC) #5
Message was sent while issue was closed.
Change committed as 270892

Powered by Google App Engine
This is Rietveld 408576698