Chromium Code Reviews| Index: tools/binary_size/diagnose_bloat.py |
| diff --git a/tools/binary_size/diagnose_bloat.py b/tools/binary_size/diagnose_bloat.py |
| index 37b5e88690d9a7363d0c990e8113dddf15f20e83..c0d8e6e06e8a6c8d2c24e057dc0c86f9c09daefa 100755 |
| --- a/tools/binary_size/diagnose_bloat.py |
| +++ b/tools/binary_size/diagnose_bloat.py |
| @@ -755,8 +755,12 @@ def main(): |
| logging.basicConfig(level=log_level, |
| format='%(levelname).1s %(relativeCreated)6d %(message)s') |
| build = _BuildHelper(args) |
| - if build.IsCloud() and args.subrepo: |
| + if build.IsCloud(): |
| + if args.subrepo: |
| parser.error('--subrepo doesn\'t work with --cloud') |
| + if build.IsLinux(): |
| + parser.error('--target-os linux doesn\'t work with --cloud') |
|
agrieve
2017/05/16 00:26:00
nit: Maybe just add a comment saying that it doesn
estevenson
2017/05/16 20:08:46
Done.
|
| + |
| subrepo = args.subrepo or _SRC_ROOT |
| _EnsureDirectoryClean(subrepo) |