third_party/WebKit/LayoutTests/battery-status/detached-no-crash.html - Issue 2880763002: [Battery] Allow usage from SecureContext or top-level browsing context only.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/battery-status/detached-no-crash.html

Issue 2880763002: [Battery] Allow usage from SecureContext or top-level browsing context only. (Closed)

Patch Set: Fix expected Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/battery-status/detached-no-crash-expected.txt » ('j') | third_party/WebKit/Source/modules/battery/NavigatorBattery.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE HTML>	1 <!DOCTYPE HTML>

2 <body>	2 <body>

3 <head>	3 <head>

4 <script src="../resources/js-test.js"></script>	4 <script src="../resources/js-test.js"></script>

5 </head>	5 </head>

6 <script>	6 <script>

7 description("Accessing navigator.getBattery() on a closed window.");	7 description("Accessing navigator.getBattery() on a closed window.");

8	8

9 window.jsTestIsAsync = true;	9 window.jsTestIsAsync = true;

10	10

11 var w;	11 var w;

12 var nav;	12 var nav;

	13 var promise;

13	14

14 function processMessage(event) {	15 function processMessage(event) {

15 if (event.data == "opened") {	16 if (event.data == "opened") {

16 nav = w.navigator;	17 nav = w.navigator;

17 shouldBeTrue("typeof(nav.getBattery()) == 'object'");	18 shouldBeTrue("typeof(nav.getBattery()) == 'object'");

18 w.close();	19 w.close();

19 w = null;	20 w = null;

20 } else if (event.data == "closed") {	21 } else if (event.data == "closed") {

21 shouldBeUndefined("nav.getBattery()");	22 promise = nav.getBattery();
	timvolodine 2017/05/25 16:01:13 nit: you can probably get rid of var promise and d nit: you can probably get rid of var promise and do nav.getBattery().then(..) directly riju_ 2017/05/30 06:36:00 Done. Show quoted text On 2017/05/25 16:01:13, timvolodine wrote: > nit: you can probably get rid of var promise and do nav.getBattery().then(..) > directly Done.
22 finishJSTest();	23 promise.then(battery => {

	24 assert_unreachable('getBattery should reject on a closed window');

	25 })

	26 .catch(error => {

	27 assert_equals(error.code, DOMException.SECURITY_ERR);
	timvolodine 2017/05/25 16:01:14 nit: maybe add a shouldBeTrue / shouldBeEqualToNum nit: maybe add a shouldBeTrue / shouldBeEqualToNumber or debug to show that this case is actually executed in the expectations.. riju_ 2017/05/30 06:36:00 Done. Show quoted text On 2017/05/25 16:01:14, timvolodine wrote: > nit: maybe add a shouldBeTrue / shouldBeEqualToNumber or debug to show that this > case is actually executed in the expectations.. Done.
	28 });

	29 finishJSTest();

23 }	30 }

24 }	31 }

25	32

26 if (window.testRunner) {	33 if (window.testRunner) {

27 testRunner.dumpAsText();	34 testRunner.dumpAsText();

28 testRunner.setCanOpenWindows();	35 testRunner.setCanOpenWindows();

29 }	36 }

30 w = window.open('../resources/window-postmessage-open-close.html');	37 w = window.open('../resources/window-postmessage-open-close.html');

31 window.addEventListener("message", processMessage, false);	38 window.addEventListener("message", processMessage, false);

32 </script>	39 </script>

33 </body>	40 </body>

OLD	NEW