Favicon url is used only if it is valid

ios/web/web_state/ui/crw_web_controller.mm

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/web/web_state/ui/crw_web_controller.h"
 
 #import <WebKit/WebKit.h>
 
 #import <objc/runtime.h>
 #include <stddef.h>
@@ skipping 2545 matching lines @@
     }
     if (!favicon->GetString("rel", &rel)) {
       DLOG(WARNING) << "JS message parameter not found: rel";
       return NO;
     }
     web::FaviconURL::IconType icon_type = web::FaviconURL::FAVICON;
     if (rel == "apple-touch-icon")
       icon_type = web::FaviconURL::TOUCH_ICON;
     else if (rel == "apple-touch-icon-precomposed")
       icon_type = web::FaviconURL::TOUCH_PRECOMPOSED_ICON;
-    urls.push_back(
-        web::FaviconURL(GURL(href), icon_type, std::vector<gfx::Size>()));
+    GURL url = GURL(href);

[Eugene But (OOO till 7-30), 2017/05/12 15:04:08]

WebContentsObserver also has DidUpdateFaviconURL. Does content throw away
invalid URLs as well? I think we should do the same thing as other platforms,
but also update WebStateObserver::FaviconUrlUpdated comments to explicitly say
whether or not the result will contain invalid URLs. 

[gambard, 2017/05/12 15:43:39]

There is a check if the URL is empty
https://cs.chromium.org/chromium/src/content/renderer/render_view_impl.cc?sq=...
So I guess there might be a check to see if it is valid?

+    if (url.is_valid()) {
+      urls.push_back(web::FaviconURL(url, icon_type, std::vector<gfx::Size>()));
+    }
   }
   if (!urls.empty())
     _webStateImpl->OnFaviconUrlUpdated(urls);
   return YES;
 }
 
 - (BOOL)handleDocumentSubmitMessage:(base::DictionaryValue*)message
                             context:(NSDictionary*)context {
   std::string href;
   if (!message->GetString("href", &href)) {
@@ skipping 2583 matching lines @@
 - (NSUInteger)observerCount {
   DCHECK_EQ(_observerBridges.size(), [_observers count]);
   return [_observers count];
 }
 
 - (NSString*)referrerFromNavigationAction:(WKNavigationAction*)action {
   return [action.request valueForHTTPHeaderField:kReferrerHeaderName];
 }
 
 @end