third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.idl - Issue 2880713002: Support combination of [OriginTrialEnabled] and [SecureContext]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.idl

Issue 2880713002: Support combination of [OriginTrialEnabled] and [SecureContext] (Closed)

Patch Set: Rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/testing/OriginTrialsTestPartial.idl ('k') | third_party/WebKit/Source/modules/webusb/NavigatorUSB.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.idl

diff --git a/third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.idl b/third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.idl

index dc2b26d586e43c8e4e3627f4fedca912b6efded1..c52f67b763fa7d047d61b85bb76146260d625507 100644

--- a/third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.idl

+++ b/third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.idl

@@ -8,9 +8,5 @@

[

OriginTrialEnabled=InstalledApp,

] partial interface Navigator {

- // TODO(mgiuca): Add [SecureContext] to this method. Currently prevented due

- // to clash with OriginTrialEnabled (so it is manually checked in the method

- // installation code instead). This can be resolved either when

- // OriginTrialEnabled is removed, or https://crbug.com/695123 is fixed.

- [CallWith=ScriptState, Measure] Promise<RelatedApplication> getInstalledRelatedApps();

+ [CallWith=ScriptState, Measure, SecureContext] Promise<RelatedApplication> getInstalledRelatedApps();

};