Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_utilities.py

Issue 2880713002: Support combination of [OriginTrialEnabled] and [SecureContext] (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/scripts/v8_utilities.py
diff --git a/third_party/WebKit/Source/bindings/scripts/v8_utilities.py b/third_party/WebKit/Source/bindings/scripts/v8_utilities.py
index a8fc0644e9cb3825df6935d3d6d5b6cfeea22957..13eb108ab634eaf9889bc8a4ec811adb8a56b529 100644
--- a/third_party/WebKit/Source/bindings/scripts/v8_utilities.py
+++ b/third_party/WebKit/Source/bindings/scripts/v8_utilities.py
@@ -389,7 +389,6 @@ def origin_trial_enabled_function_name(definition_or_member):
An exception is raised if OriginTrialEnabled is used in conjunction with any
of the following (which must be mutually exclusive with origin trials):
- RuntimeEnabled
- - SecureContext
The returned function checks if the IDL member should be enabled.
Given extended attribute OriginTrialEnabled=FeatureName, return:
@@ -406,12 +405,6 @@ def origin_trial_enabled_function_name(definition_or_member):
'not be specified on the same definition: %s'
% definition_or_member.name)
- if is_origin_trial_enabled and 'SecureContext' in extended_attributes:
- raise Exception('[OriginTrialEnabled] and [SecureContext] must '
- 'not be specified on the same definition '
- '(see https://crbug.com/695123 for workaround): %s'
- % definition_or_member.name)
-
if is_origin_trial_enabled:
trial_name = extended_attributes['OriginTrialEnabled']
return 'OriginTrials::%sEnabled' % uncapitalize(trial_name)
@@ -471,7 +464,7 @@ def on_instance(interface, member):
"""Returns True if the interface's member needs to be defined on every
instance object.
- The following members must be defiend on an instance object.
+ The following members must be defined on an instance object.
- [Unforgeable] members
- regular members of [Global] or [PrimaryGlobal] interfaces
"""

Powered by Google App Engine
This is Rietveld 408576698