Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_attributes.py

Issue 2880713002: Support combination of [OriginTrialEnabled] and [SecureContext] (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/scripts/v8_attributes.py
diff --git a/third_party/WebKit/Source/bindings/scripts/v8_attributes.py b/third_party/WebKit/Source/bindings/scripts/v8_attributes.py
index e1c2021282b04ec9f5fd158dd8a5da989e9fb26d..ed8f1a9f50eb5ac38650f1a33f813b4147d7545a 100644
--- a/third_party/WebKit/Source/bindings/scripts/v8_attributes.py
+++ b/third_party/WebKit/Source/bindings/scripts/v8_attributes.py
@@ -241,12 +241,6 @@ def filter_lazy_data_attributes(attributes):
return [attribute for attribute in attributes if is_data_attribute(attribute) and is_lazy_data_attribute(attribute)]
-def filter_origin_trial_enabled(attributes):
- return [attribute for attribute in attributes if
- attribute['origin_trial_feature_name'] and
- not attribute['exposed_test']]
-
-
def filter_runtime_enabled(attributes):
return [attribute for attribute in attributes if
not (attribute['exposed_test'] or
@@ -254,6 +248,13 @@ def filter_runtime_enabled(attributes):
attribute['runtime_enabled_feature_name']]
+def filter_conditionally_enabled(attributes):
+ return [attribute for attribute in attributes if
+ attribute['exposed_test'] or
+ (attribute['secure_context_test'] and
+ not attribute['origin_trial_feature_name'])]
+
+
################################################################################
# Getter
################################################################################

Powered by Google App Engine
This is Rietveld 408576698