Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 {% macro v8_value_to_local_cpp_value(thing) %} | 1 {% macro v8_value_to_local_cpp_value(thing) %} |
| 2 {# This indirection is just to avoid spurious white-space lines. #} | 2 {# This indirection is just to avoid spurious white-space lines. #} |
| 3 {{generate_v8_value_to_local_cpp_value(thing) | trim}} | 3 {{generate_v8_value_to_local_cpp_value(thing) | trim}} |
| 4 {%- endmacro %} | 4 {%- endmacro %} |
| 5 | 5 |
| 6 | 6 |
| 7 {% macro generate_v8_value_to_local_cpp_value(thing) %} | 7 {% macro generate_v8_value_to_local_cpp_value(thing) %} |
| 8 {% set item = thing.v8_value_to_local_cpp_value or thing %} | 8 {% set item = thing.v8_value_to_local_cpp_value or thing %} |
| 9 {% if item.error_message %} | 9 {% if item.error_message %} |
| 10 /* {{item.error_message}} */ | 10 /* {{item.error_message}} */ |
| (...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 46 {% set property_location_list = property_location_list + ['V8DOMConfiguration::k OnInstance'] %} | 46 {% set property_location_list = property_location_list + ['V8DOMConfiguration::k OnInstance'] %} |
| 47 {% endif %} | 47 {% endif %} |
| 48 {% if member.on_prototype %} | 48 {% if member.on_prototype %} |
| 49 {% set property_location_list = property_location_list + ['V8DOMConfiguration::k OnPrototype'] %} | 49 {% set property_location_list = property_location_list + ['V8DOMConfiguration::k OnPrototype'] %} |
| 50 {% endif %} | 50 {% endif %} |
| 51 {% if member.on_interface %} | 51 {% if member.on_interface %} |
| 52 {% set property_location_list = property_location_list + ['V8DOMConfiguration::k OnInterface'] %} | 52 {% set property_location_list = property_location_list + ['V8DOMConfiguration::k OnInterface'] %} |
| 53 {% endif %} | 53 {% endif %} |
| 54 {{property_location_list | join(' | ')}} | 54 {{property_location_list | join(' | ')}} |
| 55 {%- endmacro %} | 55 {%- endmacro %} |
| 56 | |
| 57 | |
| 58 {% macro check_origin_trial(member, isolate="info.GetIsolate()") -%} | |
|
iclelland
2017/05/12 15:11:49
Can you mention in the CL description that this un
chasej
2017/05/16 02:21:39
Done.
| |
| 59 ExecutionContext* executionContext = CurrentExecutionContext({{isolate}}); | |
| 60 String errorMessage; | |
| 61 if (!{{member.origin_trial_enabled_function}}(executionContext, errorMessage)) { | |
| 62 V8SetReturnValue(info, v8::Undefined(info.GetIsolate())); | |
| 63 if (!errorMessage.IsEmpty()) { | |
| 64 executionContext->AddConsoleMessage(ConsoleMessage::Create(kJSMessageSource, kErrorMessageLevel, errorMessage)); | |
| 65 } | |
| 66 return; | |
| 67 } | |
| 68 {% endmacro %} | |
| OLD | NEW |