Issue 2880643005: js_array tweaks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2880643005: js_array tweaks (Closed)

Created:
3 years, 7 months ago by sra1

Modified:
3 years, 7 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

js_array tweaks - uniform quotes - uniform naming of methods in _checkGrowable - use .slice(0), it is slightly faster than .slice() - avoid bounds and type checks in removeWhere/retainWhere BUG= R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/750de777cfb6bdfe39a153f72222dd9e791b27a1

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -16 lines)			Patch
	M	sdk/lib/_internal/js_runtime/lib/js_array.dart	View		10 chunks	+19 lines, -16 lines	0 comments	Download

Total messages: 5 (2 generated)

sra1

3 years, 7 months ago (2017-05-16 23:38:24 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
750de777cfb6bdfe39a153f72222dd9e791b27a1 (presubmit successful).