Always Ignore SIGPIPE for NaCl both in SFI mode and non SFI mode.

components/nacl/loader/nacl_helper_linux.cc

Index: components/nacl/loader/nacl_helper_linux.cc
diff --git a/components/nacl/loader/nacl_helper_linux.cc b/components/nacl/loader/nacl_helper_linux.cc
index e170c526da5b2dcd302a5e17c83b05f6d4432a7d..1489a8646225d0f85173482b5ba4d523bef045b3 100644
--- a/components/nacl/loader/nacl_helper_linux.cc
+++ b/components/nacl/loader/nacl_helper_linux.cc
@@ -91,6 +91,10 @@ void BecomeNaClLoader(base::ScopedFD browser_fd,
     nacl::nonsfi::InitializeSignalHandler();
   }
 
+  // Always ignore SIGPIPE.  We check the return value of write().

[Mark Seaborn, 2014/05/15 16:21:25]

The "we" here is rather vague (and different from the "we" in the next line :-)
).

How about: Always ignore SIGPIPE, for consistency with other Chrome processes,
and because some IPC code, such as sync_socket_posix.cc, requires this.

[hidehiko, 2014/05/16 08:21:02]

Done.

+  // We do this just before seccomp-bpf is initialized.

[Mark Seaborn, 2014/05/15 16:21:25]

Maybe omit "just", so that this doesn't become wrong if someone adds code after
this?

[hidehiko, 2014/05/16 08:21:02]

Done.

+  CHECK(signal(SIGPIPE, SIG_IGN) != SIG_ERR);

[Mark Seaborn, 2014/05/15 16:21:25]

You could use PCHECK to print errno if this fails.

[hidehiko, 2014/05/16 08:21:02]

Done.

+
   // Finish layer-1 sandbox initialization and initialize the layer-2 sandbox.
   CHECK(!nacl_sandbox->HasOpenDirectory());
   nacl_sandbox->InitializeLayerTwoSandbox(uses_nonsfi_mode);